Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Phalcon\Tag::resetInput for proper use without attempts to clear $_POST #12227

Merged
merged 1 commit into from
Oct 2, 2016
Merged

Fixed Phalcon\Tag::resetInput for proper use without attempts to clear $_POST #12227

merged 1 commit into from
Oct 2, 2016

Conversation

sergeyklay
Copy link
Contributor

Refs: #12099

@sergeyklay sergeyklay closed this Sep 16, 2016
@sergeyklay sergeyklay reopened this Sep 16, 2016
@sergeyklay sergeyklay added PHP 7 testing Tests related issue labels Sep 21, 2016
@SidRoberts
Copy link
Contributor

I don't think resetInput() should overwrite $_POST - it should only reset parameters within the Tag object.

My $0.02 :)

@sergeyklay
Copy link
Contributor Author

@SidRoberts Good catch!

@sergeyklay sergeyklay mentioned this pull request Oct 1, 2016
Closed
@sergeyklay sergeyklay changed the title Fixed Phalcon\Tag::resetInput Fixed Phalcon\Tag::resetInput for proper use without attempts to clear $_POST Oct 2, 2016
@sergeyklay sergeyklay merged commit 33db521 into phalcon:3.0.x Oct 2, 2016
@sergeyklay sergeyklay deleted the reset_input branch October 2, 2016 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing Tests related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyklay @SidRoberts