[2.0.x] Issue #11286 - Model property visibility and setter functionality #11417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just a port of #11320 ? In any case update please CHANGELOG.md |
|
@sergeyklay yes, just a port. Changelog updated. This was created because this pull request #10391 would have redundant and conflicting functionality. |
|
Could you please rebase? |
|
@sergeyklay rebase why? It has no merge conflicts and is squished to a single commit. |
…s to verify the fix.
|
It would have merged cleanly. But I rebased it anyways. |
sergeyklay
added a commit
that referenced
this pull request
Feb 17, 2016
[2.0.x] Issue #11286 - Model property visibility and setter functionality
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix __set functionality to maintain variable visibility and utilize setter methods.