Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR] allow Request::getBestLanguage() to return language without dialect #3135

Closed
quasipickle opened this issue Dec 15, 2014 · 3 comments
Closed

[NFR] allow Request::getBestLanguage() to return language without dialect #3135

quasipickle opened this issue Dec 15, 2014 · 3 comments
Labels
new feature request Planned Feature or New Feature Request

Comments

@quasipickle
Copy link
Contributor

quasipickle commented Dec 15, 2014 •
edited by sergeyklay
Loading

When I use \Phalcon\Mvc\Request->getBestLanguage() on my browser, it returns "en-US". I think it would be helpful in some cases to have a way to just return "en", as my language files won't be broken down into "en-UK", "en-US", "en-CA", etc.

Something like getBestLanguageFamily(), or a variable passed to getBestLanguage() would be helpful.
@KoriSeng KoriSeng mentioned this issue Jan 11, 2015
Closed
@maxgalbu maxgalbu mentioned this issue Jan 12, 2015
Closed
@KoriSeng KoriSeng mentioned this issue Jan 15, 2015
Closed
@dschissler

This comment was marked as abuse.

Sign in to view
@sergeyklay sergeyklay added this to the 4.0.0 milestone Jul 18, 2017
@stale stale bot added the stale Stale issue - automatically closed label Apr 16, 2018
@sergeyklay sergeyklay reopened this May 2, 2018
@stale stale bot removed the stale Stale issue - automatically closed label May 2, 2018
@niden niden mentioned this issue Feb 23, 2019
Closed
@phalcon phalcon deleted a comment from stale bot Feb 23, 2019
@niden
Copy link
Member

niden commented Feb 23, 2019

Closing in favor of #13855. Will revisit if the community votes for it, or in later versions.

@niden niden closed this as completed Feb 23, 2019
@niden niden added the new feature request Planned Feature or New Feature Request label Mar 11, 2019
@niden niden removed this from the 4.0.0 milestone Mar 11, 2019
@niden niden reopened this Mar 11, 2019
@niden niden added the 4.1 label Jun 21, 2019
@niden niden mentioned this issue Dec 9, 2019
Open
@stale stale bot added the stale Stale issue - automatically closed label Dec 23, 2019
@phalcon phalcon deleted a comment from stale bot Dec 23, 2019
@stale stale bot removed the stale Stale issue - automatically closed label Dec 23, 2019
@niden niden mentioned this issue Jan 11, 2020
Merged
5 tasks
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Added getBestLanguageIso and reorganized a few tests
1c5be3b
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] -
2a147ef
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Another correction
25aea9c
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Updated changelog
e2e3901
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Corrections after review
c989044
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Minor adjustments
ce407c8
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - If "*" is the best language return empty
e224965
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Test correction
daa4500
niden added a commit that referenced this issue Jan 11, 2020
@niden
[#3135] - Adjusted Changelog
318a19d
@niden
Copy link
Member

niden commented Jan 11, 2020

Resolved in #14698

Thank you @quasipickle

@niden niden closed this as completed Jan 11, 2020
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Added getBestLanguageIso and reorganized a few tests
c084fa0
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] -
29a99cc
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Another correction
60acc20
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Updated changelog
5821828
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Corrections after review
27c36f6
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Minor adjustments
a15ad18
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - If "*" is the best language return empty
5de3435
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Test correction
fa8db24
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#3135] - Adjusted Changelog
3b64737
@niden niden added this to Phalcon v5 Aug 25, 2022
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andresgutierrez @niden @sergeyklay @quasipickle @dschissler