Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: The method "unserialize" regarding to the interface returns "void". So results set always be empty I think. #14942

Closed
djvibegga opened this issue Apr 6, 2020 · 2 comments · Fixed by #15030
Closed

[BUG]: The method "unserialize" regarding to the interface returns "void". So results set always be empty I think. #14942

djvibegga opened this issue Apr 6, 2020 · 2 comments · Fixed by #15030
Assignees
@sergeyklay
Labels
bug A bug report status: medium Medium

Comments

@djvibegga
Copy link

cphalcon/phalcon/Mvc/Model/Resultset/Complex.zep

Line 360 in d3e9463

let resultset = serializer->unserialize(data);

@Jeckerson
Copy link
Member

https://www.php.net/manual/en/class.serializable.php

Serializable {
/* Methods */
abstract public serialize ( void ) : string
abstract public unserialize ( string $serialized ) : void
}

@Jeckerson Jeckerson added bug A bug report status: medium Medium 4.0.6 labels Apr 6, 2020
@ruudboon ruudboon changed the title The method "unserialize" regarding to the interface returns "void". So results set always be empty I think. [BUG]: The method "unserialize" regarding to the interface returns "void". So results set always be empty I think. Apr 30, 2020
@sergeyklay sergeyklay self-assigned this May 7, 2020
sergeyklay added a commit that referenced this issue May 7, 2020
@sergeyklay
Fixed SerializerInterface usage
7cadd1f 
See: #14942
sergeyklay added a commit that referenced this issue May 7, 2020
@sergeyklay
Correct tests
588fcc7 
See: #14942
@sergeyklay sergeyklay mentioned this issue May 7, 2020
Merged
5 tasks
@sergeyklay sergeyklay linked a pull request May 7, 2020 that will close this issue
Fixed SerializerInterface usage for result-sets #15030
Merged
5 tasks
@sergeyklay
Copy link
Contributor

Fixed in the 4.0.x branch. Thank you for the bug report.

niden pushed a commit that referenced this issue May 16, 2020
@sergeyklay @niden
Fixed SerializerInterface usage
1244674 
See: #14942
niden pushed a commit that referenced this issue May 16, 2020
@sergeyklay @niden
Correct tests
08a4b68 
See: #14942
niden pushed a commit that referenced this issue May 31, 2020
@sergeyklay @niden
Fixed SerializerInterface usage
0a4665f 
See: #14942
niden pushed a commit that referenced this issue May 31, 2020
@sergeyklay @niden
Correct tests
3e1f62a 
See: #14942
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed SerializerInterface usage for result-sets phalcon/cphalcon
3 participants
@djvibegga @sergeyklay @Jeckerson