Add more types for PDO #13543
Comments
|
@niden ... is this issue now resolved with all the recent changes or still WIP? |
|
@virgofx Some tests are not passing in the original PR. I think I will merge it and fix the tests after that. There is also a huge PR coming in with the local environment |
niden
added a commit
that referenced
this issue
Dec 4, 2018
* [#13543] - Work on the ENUM for PostgreSql * [#13543] - Adjusted tests * [#13543] - Corrected if clause * [#13543] - Added enum to the PG sample file * [#13543] - Trying to correct the sql file again * [#13543] - Reverting changes * [#13543] - Reverting tests and sql file * [#13543] - Initial commit for a nanobox isolated environment for tests * [#13543] - Reintroduced enum type parsing * [#13543] - Adjusted test * [#13543] - Again reverting some changes * [#13543] - Reorganized the if statement * [#13543] - Reorganized if statement * [#13543] - More sorting * [#13543] - Reorganization * [#13543] - Added bool and bit * [#13543] - Added initial describe test * [#13543] - Corrections to the table name and import file * [#13543] - Minor change to the boxfile; Added boxfile constants to the tests; Changed case in SQL file * [#13543] - Changed JSON type to TEXT * [#13543] - More work on the db * [#13543] - Another correction to the sql file * [#13543] - Test corrections * [#13543] - Test corrections * [#13543] - Corrected the bind parameter type * [#13543] - Added more fields to the column describe test * [#13543] - Added all the possible columns for the test * [#13543] - Corrected typo * [#13543] - More corrections * [#13543] - Corrections to the test * [#13543] - More test corrections * [#13543] - Correction for bool * [#13543] - Compilation of php-psr for nanobox * [#13543] - Changes for boolean * [#13543] - Disabling some columns temporarily * [#13543] - Debugging booleans * [#13543] - Minor corrections * [#13543] - Adjustments to the if statements; tinyint(1) is a boolean * [#13543] - Booleans are numbers * [#13543] - Added more fields in the array for the test * [#13543] - Adjusted the array for describe * [#13543] - Corrections for floats * [#13543] - Corrected array index * [#13543] - Added more elements to the array of the test; corrections * [#13543] - Corrected indexes in the test array * [#13543] - Added more assertions * [#13543] - Added indexes tests * [#13543] - Fixed typo in test * [#13543] - Moved the describe test to a better location; Minor corrections * [#13543] - Split tests to two files * [#13543] - Renaming and splitting tests * [#13543] - More test corrections * [#13543] - Corrected size * [#13543] - Added reference tests * [#13543] - More test corrections * [#13543] - Refactoring * [#13543] - More refactoring; Added column as object test * [#13543] - Changed control structure to stitch from if * [#13543] - Added more types for MySQL * [#13543] - Added more types * [#13543] - Aligning equals * [#13543] - Added column constants tests * [#13543] - Corrections and additions to tests * [#13543] - Removed duplicate test; Corrections to the mysql dialect * [#13543] - Corrected if statement * [#13543] - Trying to enable Mysql 5.7 * [#13543] - Trying without the password change * [#13543] - Changed casting for double to be string; Change to the schema for JSON * [#13543] - Corrections to the test and schema * [#13543] - Minor corrections * [#13543] - Initial work for postgresql columns * [#13543] - Corrected namespace * [#13543] - Fixing tests * [#13543] - More test corrections * [#13543] - Corrected schema and tests * [#13543] - Renamed the schema files; other corrections * [#13543] - Corrected schema names * [#13543] - Correction to the schema and tests * [#13543] - Added enum in the tests for mysql * [#13543] - Test corrections * [#13543] - Added enum for postgresql * [#13543] - Adjusted the schemas * [#13543] - Corrections to the dialect for postgresql, schema and adapter * [#13543] - Minor refactoring in the dialects; Adjustment to tests * [#13543] - Changed syntax for foreign references in schema; Debugging Columns * [#13543] - More test corrections * [#13543] - More test corrections * [#13543] - Corrected owner * [#13543] - Reverted the schema to what it iwas * [#13543] - Trying to correct the schema * [#13543] - Skipping reference tests for portgresql * [#13543] - Corrected parameters for test * [#13543] - Updated the changelog * [#13543] - Removed boxfile - will send upstream in different commit * [#13543] - Reformatted class to trigger build * [#13543] - Corrected names of schema files
|
Implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected and Actual Behavior
Some types are not recognized in the PDO. This is primarily due to the fact that MySQL/PostgreSql and Sqlite do not have the same types throughout.
This is an effort to offer more flexibility to the framework
The text was updated successfully, but these errors were encountered: