Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Add Phalcon\Db\Dialect\Sqlite::forUpdate #13539

Closed
TimurFlush opened this issue Oct 19, 2018 · 3 comments
Closed

[NFR] Add Phalcon\Db\Dialect\Sqlite::forUpdate #13539

TimurFlush opened this issue Oct 19, 2018 · 3 comments
Labels
bug A bug report status: low Low

Comments

@TimurFlush
Copy link

Hello
Add method forUpdate() to dialects please)

P.S Addition to the problem #13529

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 19, 2018
@niden
Copy link
Member

niden commented Oct 19, 2018

public function forUpdate(string! sqlQuery) -> string
	{
		return sqlQuery . " FOR UPDATE";
	}

Like this?

@TimurFlush
Copy link
Author

@niden Judging by the name of the method, the answer is clear.

@sergeyklay sergeyklay changed the title forUpdate [NFR] Add Phalcon\Db\Dialect\Sqlite::forUpdate Oct 19, 2018
niden added a commit that referenced this issue Oct 19, 2018
@niden
Copy link
Member

niden commented Oct 19, 2018

This has been addressed in 4.x

@niden niden closed this as completed Oct 19, 2018
@niden niden added the 4.0 label Jun 21, 2019
@niden niden removed this from the 4.0.0 milestone Oct 17, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

No branches or pull requests

3 participants