-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFR] improve memory consumption and velocity #13387
Labels
new feature request
Planned Feature or New Feature Request
Comments
pmanup
changed the title
[NFR] improve memory consumption
[NFR] improve memory consumption and velocity
May 26, 2018
sergeyklay
added
enhancement
Enhancement to the framework
New Feature Request
and removed
enhancement
Enhancement to the framework
labels
May 31, 2018
niden
added
new feature request
Planned Feature or New Feature Request
and removed
New Feature Request
labels
Mar 11, 2019
niden
added a commit
that referenced
this issue
May 12, 2019
* niden-T13387-improve-memory-consumption: [#13387] - Changed the comment [#13387] - Fixed spacing [#13387] - Updated the changelog [#13387] - Added orm.resultset_prefetch_records setting for resultsets prefetching [#13387] - Removing numRows from query Revert "[4.0.x] - Refactored render to expose also toString" Revert "[4.0.x] - Added tests for toString" Revert "[4.0.x] - Reformat the code" [4.0.x] - Reformat the code [4.0.x] - Added tests for toString [4.0.x] - Refactored render to expose also toString [4.0.x] - Anotehr update to ext/
Resolved in #14059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In file query.zep
method: executeSelect always execute numrows
/** * Check if the query has data */ if result instanceof ResultInterface && result ->numRows(){ let resultData = result; } else { let resultData = false; }
if the query is good, result always it's instanceof ResultInterface, numrows it's unnecesary
because if you work with sqlite, numrows execute other select, and if we don't want execute other select ?
If you have attibute bufer disabled in php, numrows mysql and postgre don't work, so phalcon not work.
the problem is in query.zep and resultset.zep,
resultset.zep -> if we have 32 rows, make one fetchall¿why 32? 12, 24 64 512 ??? has no sense.
so, if don't has sense, numrows it's only necessary if we want, not ALWAYS.
if we could configure this, the performance it would improve a lot.
memory and velocity.
The text was updated successfully, but these errors were encountered: