Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to interfaces #12676

Closed
18 of 20 tasks
Jurigag opened this issue Mar 3, 2017 · 2 comments
Closed
18 of 20 tasks

Add methods to interfaces #12676

Jurigag opened this issue Mar 3, 2017 · 2 comments
Assignees
@niden
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion enhancement Enhancement to the framework
Milestone
4.0.0

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Mar 3, 2017 •
edited by niden
Loading

This is list for Phalcon 4.0.0 with missing methods which should be in interfaces, feel free to add new comments here or discuss this list, i suggest one point - one interface with missing methods.

I ignored Phalcon\Http namespace cuz it's planned to switch to PSR7 anyway.

  • Phalcon\Annotations\AdapterInterface - read, write
  • Phalcon\Cache\BackendInterface - increment, decrement, flush
  • Phalcon\Cli\Router\RouteInterface - delimiter, getDelimiter
  • Phalcon\Cli\DispatcherInterface - setOptions, getOptions
  • Phalcon\Db\AdapterInterface - fetchColumn, insertAsDict, updateAsDict
  • Phalcon\Db\DialectInterface - registerCustomFunction, getCustomFunctions, getSqlExpression
  • Phalcon\Di\ServiceInterface - getParameter, isResolved
  • Phalcon\Events\ManagerInterface - hasListeners
  • Phalcon\Mvc\Model\Query\BuilderInterface - distinct, getDistinct, forUpdate, offset, getOffset
  • Phalcon\Mvc\Model\Transaction\ManagerInterface - setDbService, getDbService, setRollbackPendent, getRollbackPendent
  • Phalcon\Mvc\Model\CriteriaInterface - distinct, leftJoin, innerJoin, rightJoin, groupBy, having, cache, getColumns, getGroupBy, getHaving
  • Phalcon\Mvc\Model\ManagerInterface - isVisibleModelProperty, keepSnapshots, isKeepingSnapshots, useDynamicUpdate, isUsingDynamicUpdate, addHasManyToMany, existsHasManyToMany, getRelationRecords, getHasManyToMany, registerNamespaceAlias, getNamespaceAlias
  • Phalcon\Mvc\Model\MessageInterface - setModel, getModel, setCode, getCode
  • Phalcon\Mvc\Model\QueryInterface - getSingleResult, setBindParams, getBindParams, setBindTypes, setSharedLock, getBindTypes, getSql
  • Phalcon\Mvc\Model\RelationInterface - getParams
  • Phalcon\Mvc\Model\ResultsetInterface - setHydrateMode, getHydrateMode, getMessages, update, delete, filter
  • Phalcon\Mvc\ModelInterface::getModelsMetaData
  • Phalcon\Session\AdapterInterface - setId, status
  • Phalcon\Validation\MessageInteraface - getCode, setCode
  • Phalcon\CryptInterface - setPadding
@Jurigag Jurigag mentioned this issue Mar 3, 2017
Closed
@sergeyklay sergeyklay added this to the 4.0.0 milestone Mar 8, 2017
@sergeyklay sergeyklay added enhancement Enhancement to the framework Requires-Discussion discussion Request for comments and discussion and removed New Feature Request labels Mar 8, 2017
@Jurigag Jurigag mentioned this issue Sep 19, 2017
Closed
@stale stale bot added the stale Stale issue - automatically closed label Apr 16, 2018
@sergeyklay sergeyklay reopened this May 2, 2018
@stale stale bot removed the stale Stale issue - automatically closed label May 2, 2018
@sergeyklay sergeyklay mentioned this issue Jun 6, 2018
Closed
@phalcon phalcon deleted a comment from stale bot Dec 19, 2018
@niden niden self-assigned this Dec 19, 2018
@niden niden added the breaks bc Functionality that breaks Backwards Compatibility label Dec 21, 2018
@niden
Copy link
Member

niden commented Dec 21, 2018

  • Phalcon\Annotations\AdapterInterface - read, write <- Could not find that
  • Phalcon\Cache\BackendInterface - Cache will be refactored

@niden niden mentioned this issue Dec 21, 2018
Merged
3 tasks
niden added a commit that referenced this issue Dec 24, 2018
@niden
Merge branch 'T12676-add-methods-to-interfaces' of https://github.com…
dd4330d 
…/niden/cphalcon into niden-T12676-add-methods-to-interfaces

* 'T12676-add-methods-to-interfaces' of https://github.com/niden/cphalcon:
  [#12676] - Updated the changelog
  [#12676] - Changes to the interfaces
niden added a commit that referenced this issue Dec 24, 2018
@niden
Merge branch 'niden-T12676-add-methods-to-interfaces' into 4.0.x
f00214c 
* niden-T12676-add-methods-to-interfaces:
  [#12676] - Updated the changelog
  [#12676] - Changes to the interfaces
@niden
Copy link
Member

niden commented Dec 24, 2018

This has been addressed

@niden niden closed this as completed Dec 24, 2018
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion enhancement Enhancement to the framework
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@niden @sergeyklay @Jurigag