NFR: Get one element of the array with config->get()

[xerron]

The good from the get function is that you can set a default value.

now:

$adapter = $this->config->database->adapter ? $this->config->database->adapter : 'Mysql' ;

This is better:

$adapter = $this->config->get('database.adapter', 'Mysql');

[mzf]

Dot notation is very good idea

[sergeyklay]

I think will be better:

$adapter = $this->config->path('application.database.adapter', 'Mysql');
$adapter = $this->config->path('application/database/adapter', 'Mysql', '/');

[mzf]

Ye. Fine option

[xerron]

it's a little confusing use 'path', for me is better 'get'

[Jurigag]

But what if for some weird reason someone already have named section with dot ?

[xerron]

@Jurigag you mean this?

<?php
return new \Phalcon\Config([
    'database' => [
        'adapter' => 'Postgresql',
        'host' => 'localhost',
        'username' => 'xerron',
        'password' => 'root',
        'dbname' => 'db_uwu'
    ],
   // ...code ...
    ' section.with.dot' =>  'mmm...'
]

good question. 👍

[xerron]

@sergeyklay 👍

[michanismus]

I need this so bad! 100x thumbs up

[sergeyklay]

Will be implemented in 3.1.0

[Jurigag]

So implement it in other places too, as far as i know people wanted this in forms too and somewhere else.

[xerron]

In PHP7 default values is most readable:

$adapter =  $this->config->get('database.adapter') ?? 'Mysql';

[sergeyklay]

but it's longer and we support not only PHP7

[Jurigag]

Just add option to just call $this->config->path('application.database.adapter') without second argument, and you can use default value like php7 with null coalescing operator.

[xerron]

Well, this is good:

$adapter = $this->config->path('application/database/adapter', '/');

[daison12006013]

This is cool

[ricksanchez]

@sergeyklay Actually what @xerron needs, is only:
$adapter = $this->config->database->adapter ?: 'Mysql' ;
Not PHP7 ?? required for this, just the classic Elvis operator ?:

[sergeyklay]

@udarkness Related to #11157

[Yurist-85]

After read all above I think, the best way is something like this:

$config = new Config([ ... ]);
Use '.' [dot] notation by default but allowed to reset it if needed.
$config->setPathSeparator('/');

Use 3rd param to reset separator per request:
$val = $config->get('some.other.path.to_the.val', null, '.');

Return null if not exists (it's current behaviour I guess):
$val = $config->get('some/path/to/nonexistantval'); // null

Three ways to get default value:

$val = $config->get('some/path/to/nonexistantval', 'default_value');
$val = $config->get('some/path/to/nonexistantval') ?: 'default_value'; // 5.6
$val = $config->get('some/path/to/nonexistantval') ?? 'default_value'; // 7

And I'm absolutely sure that ->get() is much more clear and obvious than ->path() .

[fenixphp]

get($key, $default = null)

---

get('Dashboard/Main.plugins', [])

---

Up to the first dot, the path to the file. Dashboard/Main
Dashboard/Main.json or Dashboard/Main.php depending on the adapter.

After first dot using as array dot notation.

Something like this?

[Jurigag]

What? But config adapter itself accept file path, so no, it can't be like this.

[fenixphp]

А если он будет принимать путь к папке с конфигами, и получится ленивая загрузка конфигураций только там где это нужно и со значениями по умолчанию?

---

And if he will take the path to the configuration file, and you get lazy loading configurations only where it is needed and with default values?

---

Sorry translation may be inaccurate.

[sergeyklay]

Implemented in the 3.2.x branch

[sergeyklay]

@fenixphp This should be a separated NFR