Build error with sflow

[RichardMore]

Hi,

There seems to be a build issue in the 1.7.1 when building with sflow in Docker and alpine

Relevant Docker file section:

RUN \
  apk add --no-cache build-base gcc abuild binutils make && \
  apk add --no-cache libtool bzip2-dev libpcap-dev flex bison && \
  apk add --no-cache autoconf automake m4 pkgconfig

RUN \
  tar zxf v$NFDUMP_VERSION.tar.gz && \
  cd /tmp/nfdump-$NFDUMP_VERSION && \
  ./autogen.sh && \
  ./configure --enable-maxmind --enable-nfpcapd --enable-sflow --enable-nsel && \
  make && \
  cd /tmp/nfdump-$NFDUMP_VERSION && make install && \
  cd .. && \
  rm -rf nfdump-v$NFDUMP_VERSION && \
  rm /tmp/v$NFDUMP_VERSION.tar.gz && \
  apk del build-base gcc flex bison autoconf automake m4 pkgconfig

Build log:

#0 82.75 Making all in src/sflow
#0 82.75 make[2]: Entering directory '/tmp/nfdump-1.7.1/src/sflow'
#0 82.75 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf    -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT sfcapd-sfcapd.o -MD -MP -MF .deps/sfcapd-sfcapd.Tpo -c -o sfcapd-sfcapd.o `test -f 'sfcapd.c' || echo './'`sfcapd.c
#0 83.29 mv -f .deps/sfcapd-sfcapd.Tpo .deps/sfcapd-sfcapd.Po
#0 83.29 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf    -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT sfcapd-sflow_nfdump.o -MD -MP -MF .deps/sfcapd-sflow_nfdump.Tpo -c -o sfcapd-sflow_nfdump.o `test -f 'sflow_nfdump.c' || echo './'`sflow_nfdump.c
#0 83.65 mv -f .deps/sfcapd-sflow_nfdump.Tpo .deps/sfcapd-sflow_nfdump.Po
#0 83.66 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf    -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT sfcapd-sflow_process.o -MD -MP -MF .deps/sfcapd-sflow_process.Tpo -c -o sfcapd-sflow_process.o `test -f 'sflow_process.c' || echo './'`sflow_process.c
#0 85.17 mv -f .deps/sfcapd-sflow_process.Tpo .deps/sfcapd-sflow_process.Po
#0 85.18 /bin/sh ../../libtool  --tag=CC   --mode=link gcc  -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -L../lib  -o sfcapd sfcapd-sfcapd.o sfcapd-sflow_nfdump.o sfcapd-sflow_process.o ../lib/libnfdump.la ../collector/libcollector.a ../conf/libconf.a -lm  -lpthread -latomic  -lresolv -lbz2
#0 85.28 libtool: link: gcc -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -o .libs/sfcapd sfcapd-sfcapd.o sfcapd-sflow_nfdump.o sfcapd-sflow_process.o  -L../lib ../lib/.libs/libnfdump.so ../collector/libcollector.a ../conf/libconf.a -lm -lpthread -latomic -lresolv -lbz2 -pthread -Wl,-rpath -Wl,/usr/local/lib
#0 85.34 make[2]: Leaving directory '/tmp/nfdump-1.7.1/src/sflow'
#0 85.34 Making all in src/nfpcapd
#0 85.34 make[2]: Entering directory '/tmp/nfdump-1.7.1/src/nfpcapd'
#0 85.34 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf     -D_BSD_SOURCE -D_DEFAULT_SOURCE -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT nfpcapd-nfpcapd.o -MD -MP -MF .deps/nfpcapd-nfpcapd.Tpo -c -o nfpcapd-nfpcapd.o `test -f 'nfpcapd.c' || echo './'`nfpcapd.c
#0 85.70 mv -f .deps/nfpcapd-nfpcapd.Tpo .deps/nfpcapd-nfpcapd.Po
#0 85.71 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf     -D_BSD_SOURCE -D_DEFAULT_SOURCE -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT nfpcapd-packet_pcap.o -MD -MP -MF .deps/nfpcapd-packet_pcap.Tpo -c -o nfpcapd-packet_pcap.o `test -f 'packet_pcap.c' || echo './'`packet_pcap.c
#0 85.92 mv -f .deps/nfpcapd-packet_pcap.Tpo .deps/nfpcapd-packet_pcap.Po
#0 85.92 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf     -D_BSD_SOURCE -D_DEFAULT_SOURCE -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT nfpcapd-pcaproc.o -MD -MP -MF .deps/nfpcapd-pcaproc.Tpo -c -o nfpcapd-pcaproc.o `test -f 'pcaproc.c' || echo './'`pcaproc.c
#0 86.59 mv -f .deps/nfpcapd-pcaproc.Tpo .deps/nfpcapd-pcaproc.Po
#0 86.59 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf     -D_BSD_SOURCE -D_DEFAULT_SOURCE -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT nfpcapd-flowtree.o -MD -MP -MF .deps/nfpcapd-flowtree.Tpo -c -o nfpcapd-flowtree.o `test -f 'flowtree.c' || echo './'`flowtree.c
#0 87.20 mv -f .deps/nfpcapd-flowtree.Tpo .deps/nfpcapd-flowtree.Po
#0 87.20 gcc -DHAVE_CONFIG_H -I. -I../..  -I.. -I../include -I../lib -I../inline -I../collector -I../conf     -D_BSD_SOURCE -D_DEFAULT_SOURCE -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -pthread -MT nfpcapd-pcapdump.o -MD -MP -MF .deps/nfpcapd-pcapdump.Tpo -c -o nfpcapd-pcapdump.o `test -f 'pcapdump.c' || echo './'`pcapdump.c
#0 87.26 pcapdump.c: In function 'CloseDumpFile':
#0 87.26 pcapdump.c:145:39: error: 'S_IFREG' undeclared (first use in this function)
#0 87.26   145 |     int fileStat = TestPath(datefile, S_IFREG);
#0 87.26       |                                       ^~~~~~~
#0 87.26 pcapdump.c:145:39: note: each undeclared identifier is reported only once for each function it appears in
#0 87.27 make[2]: *** [Makefile:552: nfpcapd-pcapdump.o] Error 1
#0 87.27 make[2]: Leaving directory '/tmp/nfdump-1.7.1/src/nfpcapd'
#0 87.27 make[1]: *** [Makefile:436: all-recursive] Error 1
#0 87.27 make[1]: Leaving directory '/tmp/nfdump-1.7.1'
#0 87.27 make: *** [Makefile:368: all] Error 2

[phaag]

Thanks! Fixed in master repo.