Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scanner.l:298: bad test ? #197

Closed
dcb314 opened this issue Nov 29, 2019 · 1 comment
Closed

scanner.l:298: bad test ? #197

dcb314 opened this issue Nov 29, 2019 · 1 comment

Comments

@dcb314
Copy link

dcb314 commented Nov 29, 2019

scanner.l:298:18: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

if ( *c != '.' || *c != ':' || !isxdigit(*c) )

maybe better code

if ( *c != '.' && *c != ':' && !isxdigit(*c) )
phaag added a commit that referenced this issue Dec 4, 2019
@phaag
Remove unused old code. Fix for #197
b3c1362
@phaag
Copy link
Owner

phaag commented Dec 4, 2019

Thanks for the hint. This was old code, no longer used and has been now removed.

@phaag phaag closed this as completed Dec 4, 2019
@phaag phaag mentioned this issue Dec 26, 2023
Closed
phaag added a commit that referenced this issue Dec 27, 2023
@phaag
Add IP fragmentflags tag #197
3981646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcb314 @phaag