Skip to content

Commit

Permalink
xmr: tiny note in README and typo
Browse files Browse the repository at this point in the history
  • Loading branch information
tsusanka committed Oct 18, 2018
1 parent 62411cd commit d4cb008
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/apps/monero/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ REVIEWER = Tomas Susanka <[email protected]>,
Jan Pochyla <[email protected]>,
Ondrej Vejpustek <[email protected]>

ADVISORS =

-----

This Monero implementation was implemented from scratch originally for TREZOR by porting Monero C++ code to the Python codebase.
Expand Down Expand Up @@ -249,7 +247,7 @@ will load encrypted TX keys, decrypt it and generate the proof.

## Implementation notes

Few notes on desing / implementation.
Few notes on design / implementation.

### Cryptography

Expand Down Expand Up @@ -307,7 +305,8 @@ MLSAG may need to be slightly changed when implementing multisigs

Bulletproof generation and verification is implemented, however the device can handle maximum 2 batched outputs
in the bulletproof due to high memory requirements (more on that in [monero-doc]). If number of outputs is larger
than 2 the offloading to host is required.
than 2 the offloading to host is required. In such case, the bulletproofs are first computed at the host and sent to
Trezor for verification.

Bulletproof implementation is covered by unit tests, the proofs in unittest were generated by the Monero C++
implementation.
Expand Down

0 comments on commit d4cb008

Please sign in to comment.