xmr: step 08 review

src/apps/monero/protocol/signing/step_08_mlsag_done.py

@@ -1,5 +1,9 @@
 """
-MLSAG message computed.
+After all outputs were processed we can finalize the full message
+and return its hash.
+
+The name of this step 'mlsag_done' is somewhat unfortunate and
+will most likely be changed or merged to step 7.
 """
 
 from .state import State
@@ -12,7 +16,6 @@ async def mlsag_done(state: State):
         MoneroTransactionMlsagDoneAck,
     )
 
-    # state.state.set_final_message_done()  todo needed?
     await confirms.transaction_step(state.ctx, state.STEP_MLSAG)
 
     _out_pk(state)
@@ -28,7 +31,7 @@ async def mlsag_done(state: State):
 
 def _out_pk(state: State):
     """
-    Sets out_pk for the incremental hashing mlsag.
+    Hashes out_pk into the full message.
     """
     if state.output_count != len(state.output_pk_masks):
         raise ValueError("Invalid number of ecdh")