Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies to the monero PR #3

Closed
7 tasks done
tsusanka opened this issue Oct 5, 2018 · 2 comments
Closed
7 tasks done

Inconsistencies to the monero PR #3

tsusanka opened this issue Oct 5, 2018 · 2 comments

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Oct 5, 2018

Just to track inconsistencies to the code introduced in trezor/trezor-core#293 in case we decide to level it out:

  • we are currently not using the private data reconstruction on page 14 right?
  • page 22 - 2a) we are now offloading always, right?
  • page 22 - 2d) only in the case of simple RCT right?
  • on page 22 - the step 5 as in code is missing. Maybe we could add it so it's corresponding to the code? even with one line, just so the numbers relate to the code
  • 4.2 protocol selection, we are now always using the multi-step right?

I'm not saying we need to do those nit-picks, just to track what I believe is different.


  • page 22 - step 6b is actually done in the following step
  • full_message_hash vs final_message_hash
ph4r05 added a commit that referenced this issue Oct 17, 2018
@ph4r05
Copy link
Owner

ph4r05 commented Oct 18, 2018

I think this is now all sorted out.

@tsusanka
Copy link
Contributor Author

Confirmed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants