Hit Bug with GeneratePackageOnBuild:

dotnet/sdk#10335
pgodwin · Jan 5, 2022 · 03b870b · 03b870b
1 parent 53969fb
commit 03b870b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -20,9 +20,9 @@ jobs:
       - name: Build ImageSharp
         run: dotnet build --configuration Release --no-restore PictSharp.ImageSharpAdaptor -o ./bin
       - name: Pack Core
-        run: dotnet pack --no-restore PictSharp.Core -o ./packages
+        run: dotnet pack --configuration Release --no-restore PictSharp.Core -o ./packages
       - name: Pack ImageSharpAdaptor
-        run: dotnet pack --no-restore PictSharp.ImageSharpAdaptor -o ./packages
+        run: dotnet pack --configuration Release --no-restore PictSharp.ImageSharpAdaptor -o ./packages
       - name: Upload Compiled Binaries
         uses: actions/[email protected]
         with:

diff --git a/PictSharp.Core/PictSharp.Core.csproj b/PictSharp.Core/PictSharp.Core.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <RootNamespace>PictSharp</RootNamespace>
-    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+    <GeneratePackageOnBuild>False</GeneratePackageOnBuild>
     <Authors>pgodwin</Authors>
     <Description>Provides generic, core Apple PICT V2 Encoding for 1bpp, 2bpp, 4bpp, 8bpp and 32bpp images.</Description>
     <RepositoryUrl>https://github.com/pgodwin/PictSharp</RepositoryUrl>

diff --git a/PictSharp.Drawing/PictSharp.Drawing.csproj b/PictSharp.Drawing/PictSharp.Drawing.csproj
@@ -13,7 +13,7 @@
     <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <Deterministic>true</Deterministic>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
+    <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
     <Authors>pgodwin</Authors>
     <PackageId>PictSharp.Drawing</PackageId>
     <PackageTags>pictsharp;pict;encoding;compression;images;bitmap</PackageTags>

diff --git a/PictSharp.ImageSharpAdaptor/PictSharp.ImageSharpAdaptor.csproj b/PictSharp.ImageSharpAdaptor/PictSharp.ImageSharpAdaptor.csproj
@@ -5,7 +5,7 @@
     <!-- I think this is unsupported...-->
     <LangVersion>8.0</LangVersion>
     <Nullable>enable</Nullable>
-    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+    <GeneratePackageOnBuild>False</GeneratePackageOnBuild>
     <Description>PictSharp is a native .NET Library for converting images to Apple's PICT format. 
 This package provides an adaptor for ImageSharp to support saving ImageSharp images to PICT format.</Description>
     <Authors>pgodwin</Authors>