Fix JSON compatibility with MRI Ruby 2.4.0 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use the Ruby 2.4.0 compatible JSON gem, other dependencies
need to be resolved. Specifically:
bundle update json omniauth-twitter sass-rails
todd-a-jacobs
force-pushed
the
feature/json_compatibility_mri_2.4.0
branch
from
39c8f69
to
e2ad006
Compare
|
Rebased patch against your current master branch. |
|
Excellent @CodeGnome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch updates the JSON gem to a version compatible with Ruby 2.4.0. In addition, it was necessary to update the Bundler resolution for omniauth-twitter and sass-rails, as they too had a fixed dependency on the unsupported version of the JSON gem.
See Also
ruby/json#303