Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable increased login security #2651

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Enable increased login security #2651

merged 2 commits into from
Oct 20, 2024

Conversation

pglombardo
Copy link
Owner

@pglombardo pglombardo commented Oct 20, 2024

Description

This PR improves the security of logins.

If you're not using logins in your Password Pusher instance, this PR won't apply to you.

Changes:

  1. Confirmation, password recovery and other workflows will now behave the same regardless if the e-mail provided was right or wrong. This avoids confirming whether an account exists or not in the system.
  2. Account confirmations must now be done within 3 days otherwise the user will have to request a new confirmation token.
  3. User sessions now timeout in 30 minutes of no activity. Being a security product with sensitive data, this is appropriate.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo pglombardo merged commit 6fa791a into master Oct 20, 2024
5 checks passed
@pglombardo pglombardo deleted the security-improvements branch October 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant