Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change new Buffer to Buffer.from #27

Closed
wants to merge 1 commit into from
Closed

change new Buffer to Buffer.from #27

wants to merge 1 commit into from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Sep 24, 2018

new Buffer has been deprecated in node 10 (nodejs/node#8169)

`new Buffer` has been deprecated in node 10 (nodejs/node#8169)
@pgilad
Copy link
Owner

pgilad commented Sep 24, 2018

Thanks a bunch my friend!

@pgilad
Copy link
Owner

pgilad commented Sep 25, 2018

I did a mistake when merging (it didn't preserve author) so I rebased your commit and now you are properly in the git log. Sorry about that!
b2d47b9

@nektro
Copy link
Contributor Author

nektro commented Sep 26, 2018

No worries 😅 thanks so much though! Glad I could help :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants