Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrectly placed matrix delimiters #1163

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

muzimuzhi
Copy link
Member

@muzimuzhi muzimuzhi commented Jun 9, 2022

Motivation for this change

See analysis #1102 (comment).

With previous fix 438758d for similar problem #126 as reference, code change is easy to understand. To better testing, \AssertPointEquals[<tolerance>]{<point>}{<point>}, \TikzGetOnePoint{<point>}{<macro>} and some small helping commands are added to pgf-regression-test.tex.

(It's only my personal preference to try to avoid dumping boxes and writing hundreds of lines of puzzling incantations/backend-dependent specials to log. Box-content-based and PDF-based tests are more accurate, but the generated test files (.tlg and .pvt ) is harder to read.)

Fixes #1102

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

@hmenke hmenke merged commit 28917fd into pgf-tikz:master Jul 21, 2022
@muzimuzhi muzimuzhi deleted the implicite-matrix branch July 21, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Matrix library sometimes puts delimiter to the wrong place
2 participants