Generate bindings for functions provided by the cshim using bindgen.#818
Generate bindings for functions provided by the cshim using bindgen.#818thomcc wants to merge 4 commits intopgcentralfoundation:developfrom
cshim using bindgen.#818Conversation
| include_h.push(format!("pg{}.h", major_version)); | ||
|
|
||
| let bindgen_output = run_bindgen(&pg_config, &include_h) | ||
| let header_src = format!( |
There was a problem hiding this comment.
cute.
I wonder if our c-shim should be last? It probably doesn't matter, but I guess bindgen would start by picking up its #includes first.
There was a problem hiding this comment.
I wonder if our c-shim should be last?
I did it first in order to catch any cases where it is using files without including them.
There was a problem hiding this comment.
Admittedly we'd probably catch that when building the cshim, so I don't mind putting it second really.
|
Not sure why it passes locally but it seems that this needs to have the path to the cshim added to the include when building the cshim (this is more a note for future me than anybody else). That's not hard, I'll do that in a bit (this will need rebasing anyway after #813 lands). |
thomcc
force-pushed
the
shim-header
branch
2 times, most recently
from
6343504 to
1bd30b9
Compare
|
I'm going to say we can't actually do this one until we drop pg10 support, due to the bool differences. |
|
Blocked on: |
|
@workingjubilee @thomcc #830 has been merged into develop. |
|
@thomcc if you have any interest in moving this forward, please feel free to update and re-open. |
4 participants
Depends on #813, so ignore the 3 patches that come from that.
Need to think a little bit about the approach here, since this is kinda hacky. It might be better done after #798, but I'm not 100% sure yet.