Fix a problem with fns returning tuples with Attributes #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #410 we introduced some new
sql
attribute and functionality related to SQL generation.As part of this we removed the
extern_attr_tokens
frompgx-utils::sql_entity_graph::PgExtern
.Changing from:
to:
https://github.com/zombodb/pgx/blob/f653be4acd519827642d59533f06bd309befa608/pgx-macros/src/rewriter.rs#L228-L232
This caused
pgx_utils::sql_entity_graph::pg_extern::Attribute::to_tokens
to be invoked. Since it did not return what it had parsed, later when it got re-parsed forToSqlConfig
it was revealing entity graph tokens. This functionality has been fixed and these entity graph tokens now come fromto_sql_entity_graph_tokens
.