support a pgx extension compiling with no_std #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
reviewed
Jan 19, 2022
pgx-examples/nostd/sql/nostd-1.0.sql
Outdated
| This file is auto generated by pgx. | ||
|
|
||
| The ordering of items is not stable, it is driven by a dependency graph. | ||
| */ |
There was a problem hiding this comment.
I think this is an old sql file. We can delete this.
Hoverbear
reviewed
Jan 19, 2022
| @@ -290,12 +290,12 @@ extension_sql!(r#"\ | |||
| ); | |||
|
|
|||
| #[pg_extern(immutable)] | |||
| fn complex_in(input: &std::ffi::CStr) -> PgBox<Complex> { | |||
| fn complex_in(input: &pgx::cstr_core::CStr) -> PgBox<Complex> { | |||
There was a problem hiding this comment.
Hmm it'd be nice if we could provide like a from impl for this in std code so that users could just .into() it.
Hoverbear
reviewed
Jan 19, 2022
| if is_null { | ||
| None | ||
| } else if datum == 0 { | ||
| panic!("a cstring Datum was flagged as non-null but the datum is zero"); |
There was a problem hiding this comment.
Oh... We should probably make a TryFromDatum at some point so users could safely handle this.
Hoverbear
reviewed
Feb 1, 2022
| namedatalen: pgx::pg_sys::NAMEDATALEN as c_int, | ||
| float4byval: pgx::pg_sys::USE_FLOAT4_BYVAL as c_int, | ||
| float8byval: pgx::pg_sys::USE_FLOAT8_BYVAL as c_int, | ||
| len: size_of::<pgx::pg_sys::Pg_magic_struct>() as i32, |
There was a problem hiding this comment.
This is mildly dangerous for portability... according to https://doc.rust-lang.org/std/os/raw/type.c_int.html, this is almost always an i32, but it's possible it is not... Ref: rust-lang/rfcs#3012
There was a problem hiding this comment.
I think this will be fine as long as we don't end up with like avr or msp430 users.
Hoverbear
approved these changes
Feb 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plumbs through changes to allow a pgx extension to declare itself
#![no_std]and still have it to compile correctly.Use of
extern crate alloc, however, is required.There's an example in
pgx-examples/nostdthat demonstrates that all the things we officially support at least compile.A release note:
pgx::InOutFuncsorpgx:PgVarlenaInOutFuncstraits to provide custom input/output functions for a custom#[derive(PostgresType)]will need to update the signatures to referencepgx::cstr_core::CStrinstead ofstd::ffi::CStr.