Remove old .so before copying new one into place #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for an issue on new M1 Macs, as outlined in [1]. The basic rundown is: Apple has recently added mandatory signing of binaries and libraries, with associated automatic signing of locally-compiled artifacts. The signature verification uses a static in-kernel inode-based signature cache. Once cached, the signature associated with an inode is not updated. This means that by "copying over" the shared library, the kernel compares the outdated signature (from its static cache) to the new shared library contents. This workaround removes the existing .so, ensuring that a new inode is used for the newly-compiled extension .so. Fixes #328 [1]: https://developer.apple.com/documentation/security/updating_mac_software
Hoverbear
approved these changes
Dec 16, 2021
Hoverbear
reviewed
Dec 16, 2021
| // https://developer.apple.com/documentation/security/updating_mac_software | ||
| if dest.exists() { | ||
| handle_result!( | ||
| std::fs::remove_file(&dest), |
There was a problem hiding this comment.
Rustfmt will clean this indentation up later.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for an issue on new M1 Macs, as outlined in 1.
The basic rundown is: Apple has recently added mandatory signing of
binaries and libraries, with associated automatic signing of
locally-compiled artifacts.
The signature verification uses a static in-kernel inode-based signature
cache. Once cached, the signature associated with an inode is not
updated.
This means that by "copying over" the shared library, the kernel
compares the outdated signature (from its static cache) to the new
shared library contents.
This workaround removes the existing .so, ensuring that a new inode is
used for the newly-compiled extension .so.
Fixes #328