style: simplify some statements for readability #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
force-pushed
the
style/simplify-some-statements-for-readability
branch
from
f2221d7 to
064f167
Compare
hamirmahal
commented
Dec 15, 2024
pgrx/src/datum/unbox.rs
Outdated
Comment on lines
125
to
128
| type As<'src> = &'src str where Self: 'src; | ||
| type As<'src> | ||
| = &'src str | ||
| where | ||
| Self: 'src; |
There was a problem hiding this comment.
...I would prefer not to?
There was a problem hiding this comment.
That's how the version of rustup in CI formats things.
There was a problem hiding this comment.
Can these have #[rustfmt::skip] instead?
There was a problem hiding this comment.
Hmm... I'll take a look right now.
hamirmahal
force-pushed
the
style/simplify-some-statements-for-readability
branch
from
064f167 to
16a789f
Compare
workingjubilee
requested changes
Dec 18, 2024
Comment on lines
618
to
624
| let sql_graph_entity_fn_name = syn::Ident::new( | ||
| &format!("__pgrx_internals_aggregate_{}", snake_case_target_ident), | ||
| &format!("__pgrx_internals_aggregate_{snake_case_target_ident}"), | ||
| target_ident.span(), |
There was a problem hiding this comment.
All the cases where this Ident::new pattern is used should remain the same for reasons that are somewhat complex and have to do with "this pattern is suboptimal, but dtolnay/quote#206 is too, and it's not just a formatting difference."
|
Tests can be fixed with |
hamirmahal
force-pushed
the
style/simplify-some-statements-for-readability
branch
from
16a789f to
e7fd0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1961