Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect statistics from pg_stat_io (Postgres 16+) #553

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Collect statistics from pg_stat_io (Postgres 16+) #553

wants to merge 3 commits into from

Conversation

seanlinsley
Copy link
Member

@seanlinsley seanlinsley commented Jun 26, 2024 •
edited
Loading

https://www.postgresql.org/docs/current/monitoring-stats.html#MONITORING-PG-STAT-IO-VIEW

Todo:

  • refactor to use enums instead of strings for the classification columns
  • handle stats_reset properly
  • rename runner/queries.go, maybe to runner/full_1min.go?

lfittl
lfittl reviewed Jun 26, 2024
View reviewed changes
runner/diff.go Outdated Show resolved Hide resolved
lfittl
lfittl reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfittl lfittl lfittl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanlinsley @lfittl