Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #173 #174

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Fix for issue #173 #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e06c489
Support gym>=0.24.0; gym==0.24.0 uses py-ale==0.7.5. Environment memb…
jfrancis71 Jun 13, 2022
c7cc2df
Black'ify previous commit
jfrancis71 Jun 20, 2022
f09e108
Bugfix to gym version comparison, now uses package "packaging" for this.
jfrancis71 Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pfrl/wrappers/atari_wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import gym
import numpy as np
from gym import spaces
from packaging import version

import pfrl

Expand Down Expand Up @@ -37,9 +38,10 @@ def reset(self, **kwargs):
if self.override_num_noops is not None:
noops = self.override_num_noops
else:
noops = self.unwrapped.np_random.randint(
1, self.noop_max + 1
) # pylint: disable=E1101
if version.parse(gym.__version__) >= version.parse("0.24.0"):
noops = self.unwrapped.np_random.integers(1, self.noop_max + 1)
else:
noops = self.unwrapped.np_random.randint(1, self.noop_max + 1)
assert noops > 0
obs = None
for _ in range(noops):
Expand Down