Skip to content

Prevent the issue anyhow #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuenishi merged 1 commit into from
Oct 18, 2023
Merged

Prevent the issue anyhow #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ...cm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,26 @@ private boolean updateContainerState(final DatanodeDetails datanode,
/*
* The container is deleted. delete the replica.
*/
deleteReplica(containerId, datanode, publisher, "DELETED");
/**
* Note: (╯°□°）╯︵ ┻━┻
* We identified that the data loss was caused here by SCM in issue
* 1180. We are not sure why the container is marked as DELETED even
* though there are still some active blocks there (moreover, why the
* hell the blocks in the container was deleted?). Current hypothesis
* is that the container was somehow directly marked eligible for
* deletion by LegacyReplicationManager. As a workaround, we'll keep
* *ALL* direct deletion of containers on hold, until we get new
* modern replication manager in 1.4.0.
* The downside of this workaround would be we'll get no container
* deletion, but that's not that important - because we'll be able
* to reclaim disk space without it; blocks will be deleted by
* deletion services by online deletion. The benefit of avoiding
* data loss is much more important.
* We'll be monitoring this log ................
*/
logger.warn("deleteReplica(container={}, dn={}, publisher={}",
containerId, datanode, publisher);
// deleteReplica(containerId, datanode, publisher, "DELETED");
ignored = true;
break;
default:
Expand Down