Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up / reduce redundancy in processing the plotInfoTable csv files #63

Open
iantaylor-NOAA opened this issue Sep 9, 2022 · 0 comments
Assignees
Labels
type --- feature feature requests and enhancement

Comments

@iantaylor-NOAA
Copy link
Contributor

Note

This may be more of an {r4ss} issue than a {sa4ss} one, but my priority is satisfying the needs of {sa4ss} developers and users, so posting here.

Problem

{r4ss} writes the plotInfoTable csv files for each run which get combined/merged by r4ss::SS_html(). However, {sa4ss} skips the html step so requires a redundant merging of the files in https://github.com/nwfsc-assess/sa4ss/blob/master/R/get_plotinfo.R.

There have been problems with these files related to the time stamp on the png files, I think when the files were manually edited (where here I commented out the line that applies as.POSIXlt(): r4ss/r4ss@e41135b.

There's also this stale branch from 2020 with what looks like some new useful checks in the csv file merging process: r4ss/r4ss@main...html

Proposal

Create a separate function within {r4ss} to merge the csv files outside of r4ss::SS_html() that can be called by {sa4ss}.

An alternative would be to have r4ss::SS_plots() overwrite lines in the existing csv file associated with the files that are getting overwritten. I don't want to just wipe out the csv file with each new call to that function because I'd like to maintain the option to create different subsets of the plots with multiple calls to r4ss::SS_plots() (e.g. to change the plot dimensions for some that need to be taller or wider).

@iantaylor-NOAA iantaylor-NOAA added the type --- feature feature requests and enhancement label Sep 9, 2022
@kellijohnson-NOAA kellijohnson-NOAA changed the title clean up / reduce redundancy in processing hte plotInfoTable csv files clean up / reduce redundancy in processing the plotInfoTable csv files Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type --- feature feature requests and enhancement
Projects
None yet
Development

No branches or pull requests

2 participants