Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpansionFactor_1 Numerator best practices are maybe not the best #17

Open
6 tasks
kellijohnson-NOAA opened this issue Apr 5, 2019 · 0 comments
Open
6 tasks
Labels
priority: high The highest priority level in terms of what needs to be done. status: question Questions about the issue need answered topic: code Related to R code within this package type: enhancement
Milestone

Comments

@kellijohnson-NOAA
Copy link
Contributor

I tried to note with comments in the EF1_Numerator.R script where additional questions with the states need to be asked. Largely, this refers to when the "best" data isn't available for species-specific landing weight.
Major issues are summarized here

  • California - doesn't sample by species, so TOTAL_WGT will include weights of other species in the landings
  • Oregon - doesn't always supply EXP_WT and TOTAL_WGT can be just the amount of the tow that pertains to a given sample not the total species-specific landings, i.e., this can be more like cluster_wgt imo.
  • Washington - samples dressed fish and TOTAL_WGT will be dressed weight, but RWT_LBS is not always available when the landings are dressed, one can check for this using FISH_LENGTH_TYPE because alternate length or fork length signify dressed landings; only sablefish will be dressed because Theresa (WDFW) said it is illegal for other species to be dressed and even though they come in sometimes (i.e., lingcod) they are not sampled.
  • Grading might be leading to different weighting here. Need to make sure that each state ends up giving a similar measure, i.e., a landing weight of all grades or one grade. Not sure????
    Tasks:
  • When is it better to use a different column, i.e., TOTAL_WGT or RWT_LBS when EXP_WT or RWT_LBS isn't available given that the current alternative is a median that can be quite different.
  • How many values should be used in the median, right now if it is generated then it is used without respect to sample size.
  • Email Theresa to ask what to do when RWT_LBS is not available and the FISH_LENGTH_TYPE is "A" or "F".
  • Email Ali to see what best practices should be put in place when EXP_WT is not available. Hopefully she will suggest that all samples get an EXP_WT behind the scenes from them given multiple things go into it or the sample gets tossed. EXP_WT is missing in the early years.
  • Keep working with Mel to get the CLUSTER_WGT to reflect real weights and not numbers of fish within a sample. Not entirely sure why we can't use RWT_LBS here because it looks like it is species specific but not positive.
  • Think hard about grading and ensure it is properly taken care of for OR and CA.
@kellijohnson-NOAA kellijohnson-NOAA added type: enhancement status: question Questions about the issue need answered topic: code Related to R code within this package priority: high The highest priority level in terms of what needs to be done. labels May 4, 2022
@kellijohnson-NOAA kellijohnson-NOAA added this to the year_2022 milestone May 4, 2022
@kellijohnson-NOAA kellijohnson-NOAA modified the milestones: year_2022, year_2023 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The highest priority level in terms of what needs to be done. status: question Questions about the issue need answered topic: code Related to R code within this package type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant