Add functionality to remove fish with ages from length data when using marginal ages #110
Labels
priority: low
The lowest level priority, i.e., not urgent.
status: question
Questions about the issue need answered
topic: code
Related to R code within this package
type: enhancement
Is your feature request related to a problem? Please describe.
In the past, we have used all length data to create length compositions while also using the ages from a subset of these fish as marginal age data resulting in double use for some of the data. Then the ad hoc "fix" for this was to then apply a lambda weight in the model of 0.50 to both the lengths and the marginal ages. In reality, the number of records used twice across the lengths and ages likely is not 50 percent or even close to this.
Describe the solution you'd like
Across all of our data processing packages, we should subset the lengths used to create the length composition data to only those lengths that do not have ages with them if the user is planning on using the associated age data as marginals. I think we could go about this in a couple of different ways 1) add an input to processing functions for the user to specify how they want the data processed, 2) nest the length processing within the age processing function such that if someone works the data up as CAAL all lengths are retained and if marginals are requested the length data are subset, or 3) the length processing function produces two output automatically that represent all lengths and then the lengths subset.
Describe alternatives you've considered
Alternatively, users could do the subsetting themselves outside of the processing function putting the choice and approach in their hands. This would be the current way to get around using the lambdas in the model to reduce the likelihood of these data.
Additional context
The one item that we may want to carefully think through is how the subsetting of fish lengths that have ages would impact the composition expansions. Removing a portion of lengths from a trip or haul would result in the remaining lengths, which may vary from those removed, having increased influence in the expansions which may not be ideal. Ultimately, I posted this issue to trigger thought on this topic so was as a collective can decide if this is something we should be considering for future assessment cycles.
The text was updated successfully, but these errors were encountered: