Pass hurl args #10
Merged
Pass hurl args #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `vim.system` we get better type coersion and general support from libuv. Jobstart is primarily meant to be used from vimscript, not lua. Per `:h jobstart` it recommends using `vim.system`. This also makes it easier to handle building the commands list for hurl as now we only have to manage a table. This is the first of a few commits related to pfeiferj#9 and pfeiferj#7.
Something to do for the future is command completions for the `Hurl` command, but for now this permits flag passing. Closes pfeiferj#9
This reverts commit 84f763d. This was reverted because it came to my attention (thanks clason) that all the `vim` functions that were in use are only valid in Neovim `0.10` currently 😔
PriceHiller
force-pushed
the
pass-hurl-args
branch
from
9f2e231 to
c8a55b4
Compare
pfeiferj
reviewed
Jul 6, 2023
Co-authored-by: Jacob Pfeifer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
:Hurlcommand.hurl-flags.mp4
Closes #9