Use the default multiprocessing pool configuration. #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
force-pushed
the
multiprocessing/maybe-fix-hang-on-mac
branch
3 times, most recently
from
269d4ff
to
8e2a285
Compare
Previously we were forcing use of fork for all OSes to try to juice performance at the cost of running into threading issues at some point when things got more complex. They may have reached that point with CI lockups happening on macOS. Revert to the default pool setup to attempt to fix macOS hangs. To support this, also propagate any CLI global `Variables` adjustments to subprocesses. Previously these were only propagated for the current process; now the adjustments propagate through the environment so that subprocess see the same adjustments. In particular, this ensures subprocess use the same `PEX_ROOT` when a fallback has to be used to work around lack of write perms.
jsirois
force-pushed
the
multiprocessing/maybe-fix-hang-on-mac
branch
from
8e2a285
to
8a2da5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were forcing use of fork for all OSes to try to juice
performance at the cost of running into threading issues at some point
when things got more complex. They may have reached that point with CI
lockups happening on macOS. Revert to the default pool setup to attempt
to fix macOS hangs.
To support this, also propagate any CLI global
Variablesadjustmentsto subprocesses. Previously these were only propagated for the current
process; now the adjustments propagate through the environment so that
subprocesses see the same adjustments. In particular, this ensures
subprocesses use the same
PEX_ROOTwhen a fallback has to be used towork around lack of write perms.