Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from setup-python to pyenv-action. #2138

Closed
wants to merge 5 commits into from
Closed

Switch from setup-python to pyenv-action. #2138

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e774ab5
Switch from setup-python to pyenv-action.
jsirois Apr 29, 2023
cc264a1
Try versions.
jsirois Apr 29, 2023
c4bf4d4
De-quote and `s/--/-/`.
jsirois Apr 29, 2023
b9b73ca
Try 3 digit explicit pyenv version matches.
jsirois Apr 29, 2023
82fb12e
Fix copy-pasta in PyPy jobs.
jsirois Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 44 additions & 93 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ defaults:
shell: bash
env:
_PEX_TEST_PYENV_ROOT: .pyenv_test
# We use this to skip exposing same-versioned Pythons present on Linux hosts. These otherwise can
# collide when attempting to load libpython<major>.<minor><flags>.so and lead to mysterious errors
# importing builtins like `fcntl` as outlined in https://github.com/pantsbuild/pex/issues/1391.
_PEX_TEST_PYENV_VERSIONS: "2.7 3.7 3.10"
_PEX_PYENV_PYPY_RELEASE: 7.3.11
concurrency:
group: CI-${{ github.ref }}
# Queue on all branches and tags, but only cancel overlapping PR burns.
Expand All @@ -33,10 +30,11 @@ jobs:
# complete history.
fetch-depth: 0
- name: Setup Python 3.8
uses: actions/setup-python@v4
uses: gabrielfalcao/pyenv-action@v13
with:
# We need to keep Python 3.8 for consistent vendoring with tox.
python-version: "3.8"
versions: 3.8.16
default: 3.8.16
- name: Check Formatting, Types, Vendoring and Packaging
uses: pantsbuild/actions/run-tox@e63d2d0e3c339bdffbe5e51e7c39550e3bc527bb
with:
Expand All @@ -48,47 +46,37 @@ jobs:
strategy:
matrix:
include:
# N.B.: We need 20.04 for Python 2.7 & 3.5 tool cache support.
- os: macos-12
python-version: [ 2, 7 ]
python-version: [ 2, 7, 18 ]
pip-version: 20
- os: ubuntu-20.04
python-version: [ 2, 7 ]
- os: ubuntu-22.04
python-version: [ 2, 7, 18 ]
pip-version: 20
- os: ubuntu-20.04
python-version: [ 3, 5 ]
- os: ubuntu-22.04
python-version: [ 3, 5, 10 ]
pip-version: 20
- os: macos-12
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 20
- os: ubuntu-22.04
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 20
- os: ubuntu-22.04
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 22_3_1
- os: ubuntu-22.04
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 23_1_1
steps:
- name: Calculate Pythons to Expose
id: calculate-pythons-to-expose
run: |
skip=""
if [[ "$(uname -s)" == "Linux" ]]; then
skip="${{ env._PEX_TEST_PYENV_VERSIONS }}"
fi
echo "skip=${skip}" >> $GITHUB_OUTPUT
- name: Checkout Pex
uses: actions/checkout@v3
- name: Setup Python ${{ join(matrix.python-version, '.') }}
uses: actions/setup-python@v4
uses: gabrielfalcao/pyenv-action@v13
with:
python-version: "${{ join(matrix.python-version, '.') }}"
versions: ${{ join(matrix.python-version, '.') }}
default: ${{ join(matrix.python-version, '.') }}
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@e63d2d0e3c339bdffbe5e51e7c39550e3bc527bb
with:
skip: "${{ steps.calculate-pythons-to-expose.outputs.skip }}"
- name: Cache Pyenv Interpreters
uses: actions/cache@v3
with:
Expand All @@ -101,42 +89,28 @@ jobs:
pypy-unit-tests:
name: (PyPy ${{ join(matrix.pypy-version, '.') }}) Pip ${{ matrix.pip-version }} TOXENV=pypy${{ join(matrix.pypy-version, '') }}
needs: org-check
runs-on: ${{ matrix.os }}
runs-on: ubuntu-22.04
strategy:
matrix:
include:
# N.B.: We need 20.04 for PyPy 2.7 tool cache support.
- os: ubuntu-20.04
pypy-version: [ 2, 7 ]
- pypy-version: [ 2, 7 ]
pip-version: 20
- os: ubuntu-22.04
pypy-version: [ 3, 9 ]
- pypy-version: [ 3, 9 ]
pip-version: 20
- os: ubuntu-22.04
pypy-version: [ 3, 9 ]
- pypy-version: [ 3, 9 ]
pip-version: 22_3_1
- os: ubuntu-22.04
pypy-version: [ 3, 9 ]
- pypy-version: [ 3, 9 ]
pip-version: 23_1_1
steps:
- name: Calculate Pythons to Expose
id: calculate-pythons-to-expose
run: |
skip=""
if [[ "$(uname -s)" == "Linux" ]]; then
skip="${{ env._PEX_TEST_PYENV_VERSIONS }}"
fi
echo "skip=${skip}" >> $GITHUB_OUTPUT
- name: Checkout Pex
uses: actions/checkout@v3
- name: Setup PyPy ${{ join(matrix.pypy-version, '.') }}
uses: actions/setup-python@v4
uses: gabrielfalcao/pyenv-action@v13
with:
python-version: "pypy-${{ join(matrix.pypy-version, '.') }}"
versions: pypy${{ join(matrix.pypy-version, '.') }}-${{ env._PEX_PYENV_PYPY_RELEASE }}
default: pypy${{ join(matrix.pypy-version, '.') }}-${{ env._PEX_PYENV_PYPY_RELEASE }}
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@e63d2d0e3c339bdffbe5e51e7c39550e3bc527bb
with:
skip: "${{ steps.calculate-pythons-to-expose.outputs.skip }}"
- name: Cache Pyenv Interpreters
uses: actions/cache@v3
with:
Expand All @@ -153,53 +127,43 @@ jobs:
strategy:
matrix:
include:
# N.B.: We need 20.04 for Python 2.7 tool cache support.
- os: macos-12
python-version: [ 2, 7 ]
python-version: [ 2, 7, 18 ]
pip-version: 20
- os: ubuntu-20.04
python-version: [ 2, 7 ]
- os: ubuntu-22.04
python-version: [ 2, 7, 18 ]
pip-version: 20
- os: ubuntu-22.04
python-version: [ 3, 7 ]
python-version: [ 3, 7, 16 ]
pip-version: 22_3_1
- os: ubuntu-22.04
python-version: [ 3, 7 ]
python-version: [ 3, 7, 16 ]
pip-version: 23_1_1
- os: macos-12
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 20
- os: ubuntu-22.04
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 20
- os: ubuntu-22.04
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 22_3_1
- os: ubuntu-22.04
python-version: [ 3, 11 ]
python-version: [ 3, 11, 1 ]
pip-version: 23_1_1
steps:
- name: Calculate Pythons to Expose
id: calculate-pythons-to-expose
run: |
skip=""
if [[ "$(uname -s)" == "Linux" ]]; then
skip="${{ env._PEX_TEST_PYENV_VERSIONS }}"
fi
echo "skip=${skip}" >> $GITHUB_OUTPUT
- name: Checkout Pex
uses: actions/checkout@v3
with:
# We need branches and tags for some ITs.
fetch-depth: 0
- name: Setup Python ${{ join(matrix.python-version, '.') }}
uses: actions/setup-python@v4
uses: gabrielfalcao/pyenv-action@v13
with:
python-version: "${{ join(matrix.python-version, '.') }}"
versions: ${{ join(matrix.python-version, '.') }}
default: ${{ join(matrix.python-version, '.') }}
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@e63d2d0e3c339bdffbe5e51e7c39550e3bc527bb
with:
skip: "${{ steps.calculate-pythons-to-expose.outputs.skip }}"
- name: Cache Pyenv Interpreters
uses: actions/cache@v3
with:
Expand All @@ -219,45 +183,32 @@ jobs:
pypy-integration-tests:
name: (PyPy ${{ join(matrix.pypy-version, '.') }}) Pip ${{ matrix.pip-version }} TOXENV=pypy${{ join(matrix.pypy-version, '') }}-integration
needs: org-check
runs-on: ${{ matrix.os }}
runs-on: ubuntu-22.04
strategy:
matrix:
include:
# N.B.: We need 20.04 for PyPy 2.7 tool cache support.
- os: ubuntu-20.04
pypy-version: [ 2, 7 ]
- pypy-version: [ 2, 7 ]
pip-version: 20
- os: ubuntu-22.04
pypy-version: [ 3, 9 ]
- pypy-version: [ 3, 9 ]
pip-version: 20
- os: ubuntu-22.04
pypy-version: [ 3, 9 ]
- pypy-version: [ 3, 9 ]
pip-version: 22_3_1
- os: ubuntu-22.04
pypy-version: [ 3, 9 ]
- pypy-version: [ 3, 9 ]
pip-version: 23_1_1
steps:
- name: Calculate Pythons to Expose
id: calculate-pythons-to-expose
run: |
skip=""
if [[ "$(uname -s)" == "Linux" ]]; then
skip="${{ env._PEX_TEST_PYENV_VERSIONS }}"
fi
echo "skip=${skip}" >> $GITHUB_OUTPUT
- name: Checkout Pex
uses: actions/checkout@v3
with:
# We need branches and tags for some ITs.
fetch-depth: 0
- name: Setup PyPy ${{ join(matrix.pypy-version, '.') }}
uses: actions/setup-python@v4
uses: gabrielfalcao/pyenv-action@v13
with:
python-version: "pypy-${{ join(matrix.pypy-version, '.') }}"
versions: pypy${{ join(matrix.pypy-version, '.') }}-${{ env._PEX_PYENV_PYPY_RELEASE }}
default: pypy${{ join(matrix.pypy-version, '.') }}-${{ env._PEX_PYENV_PYPY_RELEASE }}
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@e63d2d0e3c339bdffbe5e51e7c39550e3bc527bb
with:
skip: "${{ steps.calculate-pythons-to-expose.outputs.skip }}"
- name: Install Packages
run: |
# This is needed for `test_requirement_file_from_url` for building `lxml`.
Expand Down