Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test broken by pdm-pep517 1.1.3 release. #2101

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix test broken by pdm-pep517 1.1.3 release. #2101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions tests/integration/resolve/test_issue_2092.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,21 @@ def test_vcs_respects_target(
python=py38.binary,
).assert_success()

assert {
"emote_rl-23.0.0-py3-none-any.whl": (
"e136042e61a0a4f6875cbfa06e4e3fada1f23f095364daf84c18d124fc4e462a"
)
} == PexInfo.from_pex(pex).distributions
# N.B.: It would be nice to assert the hash of the distribution here as well, but it uses:
#
# [build-system]
# requires = ["pdm-pep517>=1.0.0"]
#
# This results in any new release of PDM breaking the expected hash since the WHEEL metadata
# includes the PDM version:
#
# $ unzip -qc emote_rl-23.0.0-py3-none-any.whl emote_rl-23.0.0.dist-info/WHEEL
# Wheel-Version: 1.0
# Generator: pdm-pep517 1.1.3
# Root-Is-Purelib: True
# Tag: py3-none-any
#
# Ideally, Pex could include lock information for each sdist in a lock that utilized PEP-518
# and then use that information when building wheels from those locked sdists to form a PEX.
# See: https://github.com/pantsbuild/pex/issues/2100
assert ["emote_rl-23.0.0-py3-none-any.whl"] == list(PexInfo.from_pex(pex).distributions)