Check lock can resolve platforms at creation time. #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a lock is created or updated, support specifying `--platform` or `--complete-platform` to enable up-front checks that the resulting lock will resolve for the specified platforms before materializing the lock. Fixes pex-tool#1595
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jul 13, 2022
This was broken from the get-go in pex-tool#1787. It's unclear to me how the `test_create_universal_platform_check` test added in pex-tool#1824 didn't fail from the get-go, but it does now and this fix fixes that test for the `--platform macosx_10.9_x86_64-cp-310-cp310 psutil==5.9.1` abbreviated platform case. Discovered in CI for pex-tool#1845 as a failure unrelated to that change.
jsirois
added a commit
that referenced
this pull request
Jul 13, 2022
This was broken from the get-go in #1787. It's unclear to me how the `test_create_universal_platform_check` test added in #1824 didn't fail from the get-go, but it does now and this fix fixes that test for the `--platform macosx_10.9_x86_64-cp-310-cp310 psutil==5.9.1` abbreviated platform case. Discovered in CI for #1845 as a failure unrelated to that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lock is created or updated, support specifying
--platformor--complete-platformto enable up-front checks that the resulting lockwill resolve for the specified platforms before materializing the lock.
Fixes #1595