Honor sys.executable unless macOS Framework.
#1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior fix for pex-tool#1009 undid the fix in pex-tool#860. Re-enable that fix for any case that's clearly not in the context of a macOS Framework Python build. Also add tests for pyenv shims to prevent further regressions.
jsirois
commented
Oct 9, 2020
| # N.B.: We should not need to look past `sys.executable` to learn the current interpreter's | ||
| # executable path, but on OSX there has been a bug where the `sys.executable` reported is | ||
| # _not_ the path of the current interpreter executable: | ||
| # https://bugs.python.org/issue22490#msg283859 | ||
| if binary and binary != sys.executable: | ||
| TRACER.log( |
There was a problem hiding this comment.
These logs were never viewable since they were emitted durring a subprocess that captures both stdout and stderr as part of the execute_parallel Job / Retain framework. As such, just killed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior fix for #1009 undid the fix in #860. Re-enable that fix
for any case that's clearly not in the context of a macOS Framework
Python build. Also add tests for pyenv shims to prevent further
regressions.