Do not rely on sys.executable being accurate.
#1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, OSX framework Python interpreters have had launch schemes that could lead to misreported `sys.executable`. We no longer trust `sys.executable` when caching interpreters or reading them from the cache. Fixes pex-tool#1009
Eric-Arellano
approved these changes
Sep 29, 2020
Co-authored-by: Eric Arellano <[email protected]>
jsirois
commented
Sep 29, 2020
| @@ -435,7 +455,7 @@ def create_interpreter(stdout): | |||
| if os.path.isfile(cache_file): | |||
| try: | |||
| with open(cache_file, "rb") as fp: | |||
| return SpawnedJob.completed(create_interpreter(fp.read())) | |||
| return SpawnedJob.completed(create_interpreter(fp.read(), check_binary=True)) | |||
| except (IOError, OSError, cls.Error, PythonIdentity.Error): | |||
| safe_rmtree(cache_dir) | |||
There was a problem hiding this comment.
We purge the cache right here. Note the new check_binary argument is only passed here (in the try above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, OSX framework Python interpreters have had launch schemes
that could lead to misreported
sys.executable. We no longer trustsys.executablewhen caching interpreters or reading them from thecache.
Fixes #1009