Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slightly demystify the relationship between platforms and interpreters in the library API and CLI #1047

Merged
merged 10 commits into from
Sep 28, 2020
Merged

slightly demystify the relationship between platforms and interpreters in the library API and CLI #1047

merged 10 commits into from
Sep 28, 2020

Commits on Sep 27, 2020

  1. update docstrings on resolve and download methods

    @cosmicexplorer
    cosmicexplorer committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    c11a607 View commit details
    Browse the repository at this point in the history

  2. update the --platform and --resolve-local-platforms docs

    @cosmicexplorer
    cosmicexplorer committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    ac19fb7 View commit details
    Browse the repository at this point in the history

  3. revert prior docstring changes, and add :raises ValueError:

    @cosmicexplorer
    cosmicexplorer committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    097b61e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. update CLI help

    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    cf2a276 View commit details
    Browse the repository at this point in the history

  2. now try to change the docstrings helpfully again

    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    5184435 View commit details
    Browse the repository at this point in the history

  3. revert changes to --platform CLI arg help

    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    7b6b0fc View commit details
    Browse the repository at this point in the history

  4. use john's suggestion to distinguish platforms and interpreters

    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    2889556 View commit details
    Browse the repository at this point in the history

  5. also add the clarification on built distributions to the --platform C… 

    …LI arg help
    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    e614e7d View commit details
    Browse the repository at this point in the history

  6. document tiny edge case with platform matching

    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    2fc5078 View commit details
    Browse the repository at this point in the history

  7. respond to review comments

    @cosmicexplorer
    cosmicexplorer committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    300cea7 View commit details
    Browse the repository at this point in the history