Skip to content

Commit

Permalink
Fix test broken by pdm-pep517 1.1.3 release. (#2101)
Browse files Browse the repository at this point in the history
Ideally Pex would be immune to this, but there is alot of work required
there. That work would be worthwhile - I think Pex would become the 1st
locker in the Python ecosystem robust in this way - but that is for
another day.

C.F.: #2100
  • Loading branch information
jsirois committed Mar 23, 2023
1 parent 86ecdeb commit e0efca0
Showing 1 changed file with 18 additions and 5 deletions.
23 changes: 18 additions & 5 deletions tests/integration/resolve/test_issue_2092.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,21 @@ def test_vcs_respects_target(
python=py38.binary,
).assert_success()

assert {
"emote_rl-23.0.0-py3-none-any.whl": (
"e136042e61a0a4f6875cbfa06e4e3fada1f23f095364daf84c18d124fc4e462a"
)
} == PexInfo.from_pex(pex).distributions
# N.B.: It would be nice to assert the hash of the distribution here as well, but it uses:
#
# [build-system]
# requires = ["pdm-pep517>=1.0.0"]
#
# This results in any new release of PDM breaking the expected hash since the WHEEL metadata
# includes the PDM version:
#
# $ unzip -qc emote_rl-23.0.0-py3-none-any.whl emote_rl-23.0.0.dist-info/WHEEL
# Wheel-Version: 1.0
# Generator: pdm-pep517 1.1.3
# Root-Is-Purelib: True
# Tag: py3-none-any
#
# Ideally, Pex could include lock information for each sdist in a lock that utilized PEP-518
# and then use that information when building wheels from those locked sdists to form a PEX.
# See: https://github.com/pantsbuild/pex/issues/2100
assert ["emote_rl-23.0.0-py3-none-any.whl"] == list(PexInfo.from_pex(pex).distributions)

0 comments on commit e0efca0

Please sign in to comment.