-
-
Notifications
You must be signed in to change notification settings - Fork 258
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Select PEX runtime interpreter robustly. (#1770)
Previously two proxies for interpreter applicability were used: 1. The shebang selected interpreter or the explicit interpreter used to invoke the PEX. 2. Any embedded interpreter constraints. This could lead to selecting an interpreter that was not actually able to resolve all required distributions from within the PEX, which is the only real criteria, and a failure to boot. Fix the runtime interpreter resolution process to test an interpreter can resolve the PEX before using it or re-execing to it. In the use case, the resolve test performed is cached work and leads to no extra overhead. In the re-exec case the resolve test can cost O(100ms), but at the benefit of ensuring either the selected interpreter will definitely work or no interpreters on the search path can work. Fixes #1020
- Loading branch information
Showing
7 changed files
with
198 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.