Repository navigation
feat(rulesets): relocate release-channel-tags to .github as targeted org standard (#596) #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
203dbb8
feat(rulesets): relocate release-channel-tags to .github as targeted …
don-petry 6469b3d
fix(reviews): address review comments [skip ci-relay]
donpetry-bot 5d41d7f
fix(bot): address bot feedback [skip ci-relay]
donpetry-bot 776ebfa
docs(rulesets): note these are org-level policy applied per-repo (org…
don-petry 228f5aa
Merge branch 'main' into fix/596-release-channel-tags-org-standard
donpetry-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "name": "release-channel-tags", | ||
| "target": "tag", | ||
| "enforcement": "active", | ||
| "bypass_actors": [ | ||
| { | ||
| "actor_type": "OrganizationAdmin", | ||
| "bypass_mode": "always" | ||
| }, | ||
| { | ||
| "actor_id": 3167543, | ||
| "actor_type": "Integration", | ||
| "bypass_mode": "always" | ||
| }, | ||
| { | ||
| "actor_id": 4193127, | ||
| "actor_type": "Integration", | ||
| "bypass_mode": "always" | ||
| } | ||
| ], | ||
| "conditions": { | ||
| "ref_name": { | ||
| "include": ["refs/tags/**"], | ||
| "exclude": [] | ||
| } | ||
| }, | ||
| "rules": [ | ||
| {"type": "update"}, | ||
| {"type": "deletion"} | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Consider scoping the "only sanctioned rulesets" line for clarity.
The unchanged sentence above ("
pr-qualityandcode-qualityare the only sanctioned rulesets") sits in the same section that now listsrelease-channel-tagsas a third codified ruleset (lines 155-159). It's technically about branch-protection consolidation (tags aren't in scope there), but as written it reads as contradicting the new content just below it.✏️ Suggested clarification (outside reviewed range, at line 142)
Also applies to: 155-159
🧰 Tools
🪛 LanguageTool
[uncategorized] ~134-~134: The official name of this software platform is spelled with a capital “H”.
Context: ...
release-channel-tags, are defined in.github/standards/rulesets/. See the repo-boun...(GITHUB)
🤖 Prompt for AI Agents