Skip to content

chore: add dev-lead.yml to DEPLOYABLE_WORKFLOWS #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 1 commit into from
May 19, 2026
Merged

chore: add dev-lead.yml to DEPLOYABLE_WORKFLOWS #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/deploy-standard-workflows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ SKIP_REPOS=(".github" ".github-private")
# feature-ideation.yml (requires repo-specific project_context input).
DEPLOYABLE_WORKFLOWS=(
pr-review-mention.yml
dev-lead.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep dev-lead out until its stub matches audit

Adding dev-lead.yml to the all-repo deploy list will push standards/workflows/dev-lead.yml verbatim, but that template currently calls petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@main while scripts/compliance-audit.sh checks downstream repos for petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1 (see check_centralized_workflow_stubs). In any repo touched by this deployment, the deploy script’s own dry-run can report “already compliant” because it compares against the template, but the org compliance audit will still flag the workflow as non-canonical. Please align the dev-lead template/audit expectation before enabling it for bulk deployment.

Useful? React with 👍 / 👎.

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding dev-lead.yml to the DEPLOYABLE_WORKFLOWS list enables verbatim synchronization across all repositories. However, the dev-lead.yml template itself (lines 12-13) contains a comment stating it 'may be freely modified on PR branches to adjust triggers'. There is a conflict here: if a repository owner customizes the triggers, those changes will be silently overwritten by this script whenever the central template's uses: version is updated or if the script is run with --force. If the workflow is intended to be customizable at the repository level, it should likely be excluded from this list (similar to feature-ideation.yml). If it should be enforced verbatim, the misleading comment in standards/workflows/dev-lead.yml should be removed to avoid developer confusion.

agent-shield.yml
auto-rebase.yml
claude.yml
Expand Down