Skip to content

fix(compliance): disable false positive reusable-workflow-path-duplicate-github check #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 1 commit into from
Apr 28, 2026
Merged

fix(compliance): disable false positive reusable-workflow-path-duplicate-github check #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 10 additions & 33 deletions scripts/compliance-audit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,42 +220,19 @@ check_action_pinning() {
}

# ---------------------------------------------------------------------------
# Check: Reusable workflow path syntax (no duplicate .github/ segments)
# Check: Reusable workflow path syntax
# ---------------------------------------------------------------------------
# NOTE: The correct pattern IS petry-projects/.github/.github/workflows/...
# because the first .github is the repository name, and the second .github
# is the directory path within that repository. This check is disabled as
# a known false positive per petry-projects/.github standards.
#
# Reference: https://docs.github.com/en/actions/using-workflows/reusing-workflows
# Example: uses: petry-projects/.github/.github/workflows/claude-code-reusable.yml@v1
check_reusable_workflow_paths() {
local repo="$1"

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_reusable_workflow_paths now declares local repo="$1" but never uses it (the function immediately returns). ShellCheck will flag this as an unused variable (SC2034), which can fail CI. Remove the local assignment, or reference the value (e.g., via a no-op like : "$1") while keeping the signature.

Suggested change
local repo="$1"
: "$1"

Copilot uses AI. Check for mistakes.

# List workflow files
local workflows
workflows=$(gh_api "repos/$ORG/$repo/contents/.github/workflows" --jq '.[].name' 2>/dev/null || echo "")

for wf in $workflows; do
[[ "$wf" != *.yml && "$wf" != *.yaml ]] && continue

local content
content=$(gh_api "repos/$ORG/$repo/contents/.github/workflows/$wf" --jq '.content' 2>/dev/null || echo "")
[ -z "$content" ] && continue

local decoded
decoded=$(echo "$content" | base64 -d 2>/dev/null || echo "")
[ -z "$decoded" ] && continue

# Check for incorrect path with duplicate .github/ segment
# INCORRECT: petry-projects/.github/.github/workflows/...
# CORRECT: petry-projects/.github/workflows/...
local bad_paths
bad_paths=$(echo "$decoded" | grep -E 'uses:[[:space:]]*petry-projects/\.github/\.github/workflows/' || true)

if [ -n "$bad_paths" ]; then
local count
count=$(echo "$bad_paths" | wc -l | tr -d ' ')
local examples
examples=$(echo "$bad_paths" | head -2 | sed 's/^[[:space:]]*//' | paste -sd ', ' -)
add_finding "$repo" "workflow-syntax" "reusable-workflow-path-duplicate-github" "error" \
"CRITICAL: Workflow \`$wf\` has $count reusable workflow reference(s) with incorrect path syntax (path does not exist). This causes the workflow to FAIL at runtime. MUST be fixed. Change from: \`petry-projects/.github/.github/workflows/\` Change to: \`petry-projects/.github/workflows/\` (remove the first .github/ — the second is the path within the repo)" \
"standards/ci-standards.md#action-pinning-policy"
fi
done
# This check is intentionally disabled — the double .github/ pattern is correct
return 0
}

# ---------------------------------------------------------------------------
Expand Down
Loading