Repository navigation
chore: repin centralized stubs to next ring channel (#870) - #923
Conversation
Move this repo's 6 #482 reusable caller stubs from their pre-ring pins (@stable / @v1 / @v2 / SHA) onto the canary-ring `<name>/next` channels (epic #495). The next channels were cut at the currently-running proven version (376a4fcb), so this is a zero-behavior-change repin — promotion to newer code is a separate soak-gated step. The ring-aware compliance audit (petry-projects/.github#529) already accepts these channels, so dev-lead remediation will not revert them (#482 lesson). Refs #870
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@donpetry-bot please review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Review limit reached
More reviews will be available in 27 minutes and 41 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes. |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
dev-lead's auto-remediation (7dc7c16) partly reverted this PR: it correctly moved the dependency-audit test to @dependency-audit/next but "fixed" the auto-rebase-stub failure by reverting auto-rebase.yml back to @auto-rebase/stable instead of updating the test — the #482 revert-collision pattern. This restores the intended next-channel repin and updates the remaining guards: - .github/workflows/auto-rebase.yml — re-pin @auto-rebase/next. - tests/dev-lead/integration/test_auto_rebase_stub.py — EXPECTED_REF @auto-rebase/stable → @auto-rebase/next. - .github/workflows/test-dev-lead.yml — auto-rebase-stub step name → /next. - tests/test_dependabot.bats — assert dependabot-automerge/next and reject any off-channel pin (vN / SHA / stable / ringN). dev-lead's dependency-audit/next changes are kept as-is. All five .github-private reusable stubs are now on their <name>/next channels; the ring-aware compliance audit (petry-projects/.github#529) accepts them. Refs #870
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-25T04:18:11Z. |
|
@donpetry-bot please review — repin completed; stub-pin guards updated to the next channel and all checks green. |
|
@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 28c25eaa370a41d544d2d08a7d8feaf5db241a99
Review mode: triage-approved (single reviewer)
Summary
Zero-behavior-change repin of 5 first-party reusable caller stubs (agent-shield, auto-rebase, dependabot-automerge, dependency-audit, pr-review-mention) from pre-ring pins (@v1/@v2/@stable/SHA) onto their /next ring channels (epic #495, #870), with matching stub-pin guard tests updated. Channels were cut at the running proven version 376a4fc, so no code promotion occurs here.
Linked issue analysis
No closing-issue link (Refs #870, epic #495 — intentionally a ref, not a fix). The PR substantively performs the next-channel repin described: every stub and its guard test is moved consistently, and AGENTS.md §'Release channel tags & the mutable-ref exception' (lines 158-183) explicitly sanctions these mutable channel tags on first-party callers and instructs audits NOT to flag them as unpinned.
Findings
No blocking issues.
- Standards: moving from SHA/@vn to @/next is the documented, sanctioned version-selection mechanism for first-party reusables (AGENTS.md mutable-ref exception; ring-aware audit petry-projects/.github#529). Not a supply-chain smell — the release-channel-tags ruleset restricts who can move these tags.
- Consistency: all 5 workflow uses: refs, plus test_auto_rebase_stub.py (EXPECTED_REF), test_dependency_audit_stub.py (EXPECTED_USES), test_dependabot.bats (channel + tightened off-channel rejection regex), and test-dev-lead.yml step names are aligned to /next.
- Secret scan: no credential-like content in the diff (only uses: refs and test strings); CI gitleaks check passed.
- Nit (non-blocking): PR body says '6 stubs' while the final commit and diff cover 5 — a doc count discrepancy only.
CI status
All required checks green: CodeQL (actions+python), Secret scan (gitleaks), shellcheck, bats, unit-tests, validate-fixtures, stub-structure, auto-rebase-stub, dependency-audit-stub, SonarCloud (quality gate passed), CodeRabbit status SUCCESS. Only expected SKIPs (dependabot audit ecosystem jobs, dev-lead ci-relay). mergeStateStatus BLOCKED reflects the pending org-leads review requirement, not a failing check.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
2 participants
Repins this repo's #482 reusable caller stubs onto the canary-ring
<name>/nextchannels (epic #495).The
nextchannels were cut at the currently-running proven version (376a4fcb), so this is a zero-behavior-change repin — promotion to newer code is a separate soak-gated step. The ring-aware audit (petry-projects/.github#529, merged) already accepts these channels, so dev-lead remediation will not revert them (#482 lesson).Refs #870
🤖 Generated with Claude Code