Repository navigation

feat: implement issue #898 — pr-review self-review deadlock: `ci-pending` skip + "already reviewed" marker blocks approval once CI goes green - #899

Merged

don-petry merged 153 commits into

mainfrom

dev-lead/issue-898-20260621-2309

Jun 24, 2026

Merged

feat: implement issue #898 — pr-review self-review deadlock: `ci-pending` skip + "already reviewed" marker blocks approval once CI goes green#899
don-petry merged 153 commits into
mainfrom
dev-lead/issue-898-20260621-2309

Commits on Jun 23, 2026
- Add scheduled PR review agent
  
  authored and
  donpetry-bot
  committed
  924e67c
- Use Claude Code OAuth token instead of API key
  
  authored and
  donpetry-bot
  committed
  dcef6e6
- Enforce single-PR scope and default to dry-run
  
  authored and
  donpetry-bot
  committed
  442390f
- Add 3-model council + commit-SHA-aware iterative review
  
  authored and
  donpetry-bot
  committed
  cbbc998
- Upgrade maintainability lens from Haiku 4.5 to Sonnet 4.6
  
  authored and
  donpetry-bot
  committed
  8278dc2
- Go-live improvements for PR review agent (#2)
  
  authored and
  donpetry-bot
  committed
  7457d5e
- Add Claude delegation, auto-merge, and rebase handling (#3)
  
  authored and
  donpetry-bot
  committed
  ffec660
- Optimize review: small-PR and incremental fast paths (#4)
  
  authored and
  donpetry-bot
  committed
  602006d
- Add Claude Code workflow (#8)
  
  authored and
  donpetry-bot
  committed
  2b221f6
- feat: add Copilot engine support via REVIEW_ENGINE toggle (#5)
  
  authored and
  donpetry-bot
  committed
  73be041
- feat: inline Claude Code workflow to access repo secrets directly (#9)
  
  authored and
  donpetry-bot
  committed
  d8aeaf3
- feat: cross-engine adversarial rubber duck review (#11)
  
  authored and
  donpetry-bot
  committed
  01ae188
- docs: clarify PR review batching issue
  
  DJ
  authored and
  donpetry-bot
  committed
  4daec8d
- feat: CI gate + poll-loop rebase wait across all review prompts (#14)
  
  authored and
  donpetry-bot
  committed
  ffa270e
- docs: update repo references from self to pr-review-agent
  
  DJ
  authored and
  donpetry-bot
  committed
  4ed4a95
- feat: add car-hunt skill for used vehicle research and ranking
  
  authored and
  donpetry-bot
  committed
  0b2fba3
- fix: fix FB Marketplace links, improve AutoTrader fetch, add Sheets export step
  
  authored and
  donpetry-bot
  committed
  f27df5f
- fix: add Craigslist as explicit source, enforce real-URL-only link rule
  
  authored and
  donpetry-bot
  committed
  31150f1
- fix: split zip/radius questions, rename MAX_MILES to MAX_ODOMETER
  
  authored and
  donpetry-bot
  committed
  b8ea0b1
- fix: include self-authored PRs awaiting review in agent enumeration (#16)
  
  authored and
  donpetry-bot
  committed
  a645a43
- feat: add doors/transmission fields, update-mode sheet, fix CarGurus/Craigslist approach
  
  authored and
  donpetry-bot
  committed
  a4f8328
- feat: add hard disqualification filters for finance-speak, title issues, and scam signals
  
  authored and
  donpetry-bot
  committed
  c5a2509
- feat: add Distance to Car field using Nominatim geocoding + Haversine formula
  
  authored and
  donpetry-bot
  committed
  6013296
- fix: address low result count — batch URL extraction, preview-filter before fetch, target 50+ raw
  
  authored and
  donpetry-bot
  committed
  4e94387
- fix: make cascade-action prompt explicit about gh pr review --approve
  
  DJ
  authored and
  donpetry-bot
  committed
  f3ca25c
- add: cleanup script to fix PRs with comment approvals instead of review approvals
  
  DJ
  authored and
  donpetry-bot
  committed
  8b45bae
- fix: cleanup script now requires bot account token
  
  DJ
  authored and
  donpetry-bot
  committed
  f296628
- add: workflow to fix stuck PRs using bot account token
  
  DJ
  authored and
  donpetry-bot
  committed
  75d73a3
- fix: pass GH_PAT to checkout action so workflow uses bot account
  
  DJ
  authored and
  donpetry-bot
  committed
  a7e06b4
- debug: simplify account check, add authentication debug output
  
  DJ
  authored and
  donpetry-bot
  committed
  74a732f
- docs: add comprehensive petry-review-bot setup instructions
  
  DJ
  authored and
  donpetry-bot
  committed
  7e072fe
- docs: add GitHub App setup guide (recommended approach)
  
  DJ
  authored and
  donpetry-bot
  committed
  e23395c
- docs: add comprehensive GitHub App setup documentation
  
  authored and
  donpetry-bot
  committed
  67a9294
- fix: silence auth check in fix-stuck-prs when using GitHub App token
  
  authored and
  donpetry-bot
  committed
  6eb4df4
- fix: use explicit author instead of @me in stuck PR search
  
  authored and
  donpetry-bot
  committed
  f44c61c
- fix: avoid subshell in while loop to preserve variable state
  
  authored and
  donpetry-bot
  committed
  5e0ed0a
- docs: add comprehensive status report for GitHub App setup
  
  authored and
  donpetry-bot
  committed
  4005a96
- docs: document stuck PR cleanup status and script fixes
  
  authored and
  donpetry-bot
  committed
  b1f642e
- docs: add investigation report for PR review agent workflow failures
  
  DJ
  authored and
  donpetry-bot
  committed
  b3b8cbf
- script: add backfill-approvals to retroactively apply real approvals
  
  authored and
  donpetry-bot
  committed
  3a43005
- feat: add backfill-approvals workflow to run as GitHub App bot
  
  authored and
  donpetry-bot
  committed
  7e83927
- fix: convert inner while loop to process substitution to preserve counters
  
  authored and
  donpetry-bot
  committed
  c7bcac3
- car-hunt: add VIN-deep-dive flow, printable checklists, location-tier ranking
  
  DJ
  authored and
  donpetry-bot
  committed
  5757087
- fix: re-approve PRs where approval predates last commit (stale approval)
  
  authored and
  donpetry-bot
  committed
  c9ecb9d
- fix: robustly extract JSON verdict from mixed claude --print output (#17)
  
  authored and
  donpetry-bot
  committed
  32be8cb
- fix: extract_verdict_json — check dest file first (agent Bash-write style)
  
  authored and
  donpetry-bot
  committed
  fc1aa58
- Enforce MAX_REVIEW_CYCLES cap before running the cascade (#18)
  
  authored and
  donpetry-bot
  committed
  659ce68
- Remove car-hunt skill and scheduled tasks (moved to don-petry/don-petry) (#21)
  
  authored and
  donpetry-bot
  committed
  7e589ee
- fix: harden Copilot fallback path and remove stale worktrees (#25)
  
  authored and
  donpetry-bot
  committed
  c042ac9
- ci: add pre-flight dedup check to prevent duplicate claude-issue PRs (#26)
  
  authored and
  donpetry-bot
  committed
  885f177
- refactor: migrate to machine user PAT auth (closes #27) (#28)
  
  authored and
  donpetry-bot
  committed
  4dd68db
- refactor: merge approval repair scripts into single automation
  
  authored and
  donpetry-bot
  committed
  cf49519
- feat: add @mention trigger for on-demand PR reviews (#30)
  
  authored and
  donpetry-bot
  committed
  dbd0cc4
- refactor: migrate to org-wide .github-private convention (#41)
  
  authored and
  donpetry-bot
  committed
  6209fe0
- ci: add dependabot-automerge.yml workflow (#73)
  
  authored and
  donpetry-bot
  committed
  05e8fb1
- fix(pr-review): unblock queue starvation from self-authored PRs (#96) (#97)
  
  authored and
  donpetry-bot
  committed
  5995e8a
- chore: rename GH_PAT_WORKFLOWS secret to DON_PETRY_BOT_GH_PAT (#99)
  
  authored and
  donpetry-bot
  committed
  743ebc1
- chore: remove frameworks directory (#101)
  
  authored and
  donpetry-bot
  committed
  a09f9dc
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  c0741de
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  0d86030
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  e414def
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  6b1e240
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  2b0a275
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  793d46a
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  d116adc
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  6a38187
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  ebbe854
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  15d0d6d
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  3b40a38
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  3bf3ec0
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  268e2f3
- chore: deprecate pr-review-agent — remove all traces
  
  authored and
  donpetry-bot
  committed
  7b0820d
- revert: restore all erroneously deleted files (items 4-34) (#104)
  
  authored and
  donpetry-bot
  committed
  6216922
- feat: add Gemini Pro support and optimize PR review fallback chain (#102)
  
  authored and
  donpetry-bot
  committed
  43d69cb
- fix(claude): sync inlined workflow with org standard (#109)
  
  authored and
  donpetry-bot
  committed
  ea73bd8
- ci: replace inlined claude.yml with standard thin-caller stub
  
  don-petry
  authored and
  donpetry-bot
  committed
  c517bf2
- ci: pin dependabot-automerge reusable workflow to SHA (#130)
  
  authored and
  donpetry-bot
  committed
  a10924b
- fix: restore pr-review.yml content (accidentally emptied in revert)
  
  authored and
  donpetry-bot
  committed
  dacb964
- fix: restore pr-review.yml (file was accidentally emptied)
  
  authored and
  donpetry-bot
  committed
  7c9a627
- chore(deps): bump petry-projects/.github/.github/workflows/dependency-audit-reusable.yml (#163)
  
  dependabot[bot]
  authored and
  donpetry-bot
  committed
  5ccf819
- chore(deps): bump petry-projects/.github/.github/workflows/claude-code-reusable.yml (#164)
  
  dependabot[bot]
  authored and
  donpetry-bot
  committed
  db2dd06
- chore(deps): bump petry-projects/.github/.github/workflows/dependabot-automerge-reusable.yml (#168)
  
  dependabot[bot]
  authored and
  donpetry-bot
  committed
  09d4450
- fix(list-prs): search DELEGATION_ORGS and drop --checks success pre-filter
  
  don-petry
  authored and
  donpetry-bot
  committed
  70498d7
- chore(deps): bump petry-projects/.github/.github/workflows/dependabot-automerge-reusable.yml (#173)
  
  dependabot[bot]
  authored and
  donpetry-bot
  committed
  4726305
- feat(prompts/dev-lead): add human prompt template
  
  don-petry
  authored and
  donpetry-bot
  committed
  d8a0e34
- feat(prompts/dev-lead): add human-pr prompt template
  
  don-petry
  authored and
  donpetry-bot
  committed
  fcc37b2
- feat(dev-lead): implement dev-lead agent Phases 0-6
  
  authored and
  donpetry-bot
  committed
  0b9e8d7
- feat(dev-lead): Phase 1.5 — reusable workflow for cross-repo adoption + Phase 7 shadow period
  
  authored and
  donpetry-bot
  committed
  265803e
- fix(dev-lead): rate-limit detection, separate status, and retry cron (#192) (#196)
  
  authored and
  donpetry-bot
  committed
  03fb532
- fix(pr-review): handle Gemini trust-mode failure and properly route engine fallbacks (#217)
  
  authored and
  donpetry-bot
  committed
  4884546
- fix: resolve YAML syntax error in dev-lead-reusable workflow
  
  Gemini CLI
  authored and
  donpetry-bot
  committed
  21513bb
- chore: remove Phase 7 shadow period comment from dev-lead.yml
  
  don-petry
  authored and
  donpetry-bot
  committed
  0d8c1aa
- test: bypass CI check
  
  Gemini CLI
  authored and
  donpetry-bot
  committed
  9a3fb59
- fix(pr-review): remove CI bypass hack
  
  Gemini CLI
  authored and
  donpetry-bot
  committed
  9bcd21e
- fix(dev-lead): detect engine-committed changes and remove commit instructions from prompts
  
  authored and
  donpetry-bot
  committed
  10592c7
- fix(dev-lead): address PR review findings — untracked files, upstream fallback, dry-run msg, fix-ci/issue parity
  
  authored and
  donpetry-bot
  committed
  abc8e30
- fix(dev-lead): handle SonarQube Quality Gate failures (issue #279) (#280)
  
  authored and
  donpetry-bot
  committed
  0bbbf7a
- fix(dev-lead): configure git identity, surface commit/push failures, add WebFetch tool access
  
  don-petry
  authored and
  donpetry-bot
  committed
  626c601
- fix(dev-lead): resolve review threads after fixing + notify CodeRabbit on CHANGES_REQUESTED
  
  don-petry
  authored and
  donpetry-bot
  committed
  863d0fb
- fix(dev-lead): post @coderabbitai resolve on no-changes + enable auto-merge on approval
  
  don-petry
  authored and
  donpetry-bot
  committed
  8d045c9
- fix(dev-lead): relay check_run id, verify engine CLI, improve SonarCloud guidance
  
  committed
  96cc34a
- ci: add required ci.yml workflow
  
  committed
  8d0da10
- fix(ci): move shopt before yamllint call (fixes syntax error)
  
  don-petry
  authored and
  donpetry-bot
  committed
  9540b94
- fix(dev-lead): configure git user identity in fix-issue script (#326)
  
  don-petry
  authored and
  donpetry-bot
  committed
  ce8a2a9
- feat: implement issue #232 — Phase 1: Issue Triage gh-aw workflow (#284)
  
  don-petry
  and
  donpetry-bot
  committed
  84b723d
- style(ci): remove trailing blank line to fix yamllint recurring failure
  
  don-petry
  authored and
  donpetry-bot
  committed
  9a1d92f
- feat: implement issue #183 — Compliance: non-stub-claude.yml (#328)
  
  don-petry
  and
  donpetry-bot
  committed
  b18f770
- feat: implement issue #135 — Compliance: unpinned-actions-claude.yml (#330)
  
  don-petry
  and
  donpetry-bot
  committed
  1a8edfa
- feat: implement issue #184 — Compliance: non-stub-dependency-audit.yml (#346)
  
  don-petry
  and
  donpetry-bot
  committed
  62f90b7
- chore(deps): bump petry-projects/.github/.github/workflows/dependency-audit-reusable.yml (#348)
  
  dependabot[bot]
  authored and
  donpetry-bot
  committed
  736e21b
- feat(fleet-monitor): summarize token usage by workflow (#343)
  
  authored and
  donpetry-bot
  committed
  578a6ca
- feat(dev-lead): harden agent instructions with Plan→TDD→Verify→Rubber Duck→Report pattern (#358)
  
  committed
  bfbdf24
- add: force-deploy-pr-review workflow for branch-protection bypass
  
  Gemini CLI
  authored and
  donpetry-bot
  committed
  ff9769a
- add: pr-review-reusable.yml wrapper for workflow_call pattern
  
  authored and
  donpetry-bot
  committed
  9a6317b
- fix: explicitly pass secrets in pr-review-reusable.yml workflow_call
  
  authored and
  donpetry-bot
  committed
  cdb3d29
- feat: implement issue #425 — dev-lead: Incomplete issue resolution - missing code reviews and CI failures (#426)
  
  don-petry
  and
  donpetry-bot
  committed
  1a42625
- chore(deps): bump actions/checkout from 4 to 6 (#433)
  
  dependabot[bot]
  authored and
  donpetry-bot
  committed
  8e3f169
- merge: PR #353 - PR Review Agent diagnostics and transient failure hardening (resolve conflicts)
  
  authored and
  donpetry-bot
  committed
  97c3e96
- merge: PR #422 - Add deploy-pr-review.yml workflow for branch protection bypass
  
  authored and
  donpetry-bot
  committed
  9dfc955
- fix(ci): strip trailing whitespace from deploy-pr-review workflows (#441)
  
  committed
  eeaf0aa
- fix(engine): handle gemini quota exhaustion and capture stderr (#226)
  
  don-petry
  and
  donpetry-bot
  committed
  b26a00c
- feat: implement issue #396 — Compliance: non-stub-dependency-audit.yml (#481)
  
  don-petry
  and
  donpetry-bot
  committed
  8255a75
- feat: implement issue #438 — Compliance: unpinned-actions-deploy-pr-review.yml (#473)
  
  don-petry
  and
  donpetry-bot
  committed
  d7307f1
- feat: implement issue #404 — PR Review Agent — failures detected 2026-05-28 (#478)
  
  don-petry
  and
  donpetry-bot
  committed
  32c2c03
- feat: implement issue #511 — [Fleet Monitor] petry-projects/.github-private — daily-pr-review-health.yml (#527)
  
  don-petry
  and
  donpetry-bot
  committed
  e5790a7
- feat: implement issue #512 — [Fleet Monitor] petry-projects/.github-private — test-dev-lead.yml (#529)
  
  committed
  94e496a
- feat: implement issue #140 — Compliance: non-stub-dependabot-automerge.yml (#514)
  
  don-petry
  and
  donpetry-bot
  committed
  32210e7
- feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
  
  don-petry
  and
  donpetry-bot
  committed
  c3af009
- chore: retire deploy-pr-review, force-deploy, and pr-review-reusable wrappers (#536) (#542)
  
  committed
  802ca8d
- feat: implement issue #545 — Compliance: non-stub-dependency-audit.yml (#548)
  
  don-petry
  and
  donpetry-bot
  committed
  6edba30
- chore(frameworks): vendor BMAD Method v6.8.0 + Test Architect v1.19.0 (src skills) (#575)
  
  committed
  1ede913
- feat: implement issue #244 — [Fleet Monitor] petry-projects/.github-private — ci.yml (#521)
  
  don-petry
  and
  donpetry-bot
  committed
  7395b32
- chore(deps): bump the actions group across 1 directory with 8 updates (#640)
  
  authored and
  donpetry-bot
  committed
  d70da86
- feat: implement issue #582 — [Phase 1] Define held-out eval-case format + seed prompts/triage.md case set (#623)
  
  committed
  5e2770c
- feat: implement issue #583 — deterministic eval scorer (triage) over #691's holdout split (#719)
  
  don-petry
  authored and
  donpetry-bot
  committed
  1e9cf9b
- feat: implement issue #143 — Compliance: secret_scanning_non_provider_patterns (#518)
  
  committed
  fa74c1d
- feat: implement issue #695 — [Fleet Monitor] petry-projects/.github-private — .github/workflows/lint.yml (#704)
  
  committed
  4994519
- feat: implement issue #796 — Compliance: non-stub-dependency-audit.yml (#802)
  
  don-petry
  and
  donpetry-bot
  committed
  d20cb03
- feat: implement issue #797 — Compliance: non-stub-dependabot-automerge.yml (#801)
  
  don-petry
  and
  donpetry-bot
  committed
  3e82e97
- test(dogfood): comment-only touch to exercise downstream-impact on next (#850)
  
  authored and
  donpetry-bot
  committed
  9d9fb45
- revert(dogfood): remove ci-status.sh dogfood comment + re-prove downstream-impact (#854)
  
  authored and
  donpetry-bot
  committed
  fd3d29a
- docs(release): document live dev-lead next/ring channels + staged-rollout runbook (#499) (#867)
  
  committed
  b231930
- feat: implement issue #898 — pr-review self-review deadlock: `ci-pending` skip + "already reviewed" marker blocks approval once CI goes green
  donpetry-bot
  committed
  c7bfd19
- chore: apply manual instructions [skip ci-relay]
  donpetry-bot
  committed
  32894a8
- chore: apply manual instructions [skip ci-relay]
  donpetry-bot
  committed
  11f9612
- chore: apply manual instructions [skip ci-relay]
  donpetry-bot
  committed
  533bfaf
- chore: apply manual instructions [skip ci-relay]
  donpetry-bot
  committed
  4fb8d8d
- Merge branch 'main' into dev-lead/issue-898-20260621-2309
  don-petry
  authored
  c9175de
- Merge branch 'main' into dev-lead/issue-898-20260621-2309
  don-petry
  authored
  855686e
- Merge branch 'main' into dev-lead/issue-898-20260621-2309
  don-petry
  authored
  86f3b22
- Merge branch 'main' into dev-lead/issue-898-20260621-2309
  don-petry
  authored
  62930d9
- chore: apply manual instructions [skip ci-relay]
  donpetry-bot
  committed
  bc2afd8
Commits on Jun 24, 2026
- chore: apply manual instructions [skip ci-relay]
  donpetry-bot
  committed
  052fe1a

Commits

Commits on Jun 23, 2026