Repository navigation
feat: implement issue #629 — Compliance: non-stub-feature-ideation.yml - #805
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThe ChangesFeature Ideation Compliance Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new BATS test suite (tests/test_feature_ideation.bats) to enforce compliance for the .github/workflows/feature-ideation.yml workflow, ensuring it correctly pins the reusable workflow to the v1 SHA. The feedback suggests a robustness improvement in the test checking for the superseded v2 SHA: explicitly verifying the file's existence before running a negated grep command to avoid false positives from execution errors.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #805 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-19T17:13:28Z. |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: f9595ab69ef2290e4ea0888006c2d2ce3947006b
Review mode: triage-approved (single reviewer)
Summary
Compliance fix for #629: syncs .github/workflows/feature-ideation.yml to the canonical org stub, restoring the @v1 reusable pin (897e4dede… # v1) in place of the superseded v2 SHA. Also adds a bats regression test guarding the v1 pin and registers it in lint.yml. The local stub is byte-identical to the upstream source of truth except for the intended per-repo project_context / sources_file customization; the uses: line, discussion: created trigger, ideas-category/non-bot if-guard, and target_discussion input all match the standard exactly.
Linked issue analysis
Closes #629 (compliance finding: feature-ideation.yml not pinned to @v1). Substantively addressed — the reusable is now pinned to the canonical v1 SHA matching standards/workflows/feature-ideation.yml, and the new test (tests/test_feature_ideation.bats) asserts the v1 pin + # v1 annotation and forbids the old v2 SHA, preventing re-filing.
Findings
No blocking findings.
- Verified new SHA 897e4dede… is a real commit in petry-projects/.github and matches the canonical source-of-truth stub's uses: line (annotated # v1).
- discussion: created trigger is part of the vetted org standard and carries an if-guard (category.slug == 'ideas' && user.type != 'Bot'); permissions are scoped and documented. No GitHub Actions security smell introduced by this PR.
- Diff of local stub vs canonical shows only the expected project_context and sources_file customization; all protected lines match.
- MCP run_secret_scanning was not available/permitted in this run; relied on the passing gitleaks CI check. Changed files (workflow YAML + bats) contain no secret material — only git SHAs and a reference to the secret name CLAUDE_CODE_OAUTH_TOKEN, no values.
CI status
All required checks green: Lint, shellcheck/ShellCheck, bats, unit-tests, CodeQL (actions+python), Secret scan (gitleaks), agent-shield/AgentShield, SonarCloud, validate-agent-profiles, gh-aw-compile, holdout-guard, etc. The two CANCELLED entries (dev-lead / dispatch, dev-lead / ci-relay) are the bot's own superseded dispatch jobs, not test failures. mergeStateStatus BLOCKED is solely due to REVIEW_REQUIRED, which this approval addresses.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_feature_ideation.bats`:
- Around line 36-38: The grep command in the test "feature-ideation.yml uses:
line is annotated # v1" interpolates the unescaped ${REUSABLE} variable into an
Extended Regular Expression pattern, which causes special regex characters like
dots to be interpreted as wildcards instead of literal characters. This allows
malformed uses: values to pass the test. Escape the special regex characters in
${REUSABLE} before using it in the grep pattern, particularly dots and other
metacharacters that could appear in paths. Consider using sed to escape these
characters or switching to grep -F for literal string matching instead of ERE
pattern matching.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 85a4495d-3ffc-4be9-b5d8-b7fe26ba4a2c
📒 Files selected for processing (3)
.github/workflows/feature-ideation.yml.github/workflows/lint.ymltests/test_feature_ideation.bats
|
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-19T18:03:21Z. |
2 participants
Closes #629
Implemented by dev-lead agent. Please review.
Summary by CodeRabbit
Release Notes
Tests
Chores