Repository navigation
Teach cut-release.sh about persona-mention - #1298
Conversation
Registering `persona-mention` in canary-rings.json (#754) is not enough to cut its release: cut-release.sh keeps its OWN hardcoded agent allowlist (valid_agent / cross_repo_agent), and the router was absent from it — so `cut-release.sh persona-mention 1.0.0 --channel next` failed with "unknown agent". This is the two-registry drift the framework fights, in the release tooling. persona-mention is a cross-repo agent exactly like pr-review-mention: its reusable lives in petry-projects/.github, this repo holds only the caller stub, so its release/channel tags resolve against .github (CROSS_REPO_TARGET). Added it beside pr-review-mention in cross_repo_agent(), the usage comment, and the unknown-agent error string. Verification - bats tests/test_cut_release.bats: 61/61 (2 new: valid_agent + cross_repo_agent accept persona-mention). - shellcheck --severity=warning -x scripts/cut-release.sh: clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRelease tooling now recognizes ChangesPersona Mention Release Support
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for a new cross-repo agent named "persona-mention" to the release script (scripts/cut-release.sh) and includes corresponding unit tests in tests/test_cut_release.bats to verify its validation and classification. There are no review comments, and I have no feedback to provide.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the release-cutting tooling (scripts/cut-release.sh) to recognize persona-mention as a valid cross-repo agent (hosted in petry-projects/.github), addressing a two-registry drift where canary-rings.json registration alone was insufficient to cut releases.
Changes:
- Add
persona-mentionto the cross-repo agent router (cross_repo_agent) socut-release.sh persona-mention ...works. - Update
cut-release.shusage docs and the “unknown agent” error message to includepersona-mention. - Add Bats unit coverage ensuring
persona-mentionis accepted and classified as cross-repo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/cut-release.sh |
Adds persona-mention to the cross-repo agent allowlist and updates user-facing messaging accordingly. |
tests/test_cut_release.bats |
Adds unit tests verifying persona-mention is a valid agent and is treated as cross-repo. |
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1298 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Dev-Lead — waiting on PR blockers (intent: fix-reviews)PR: #1298 |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 1f6466b12e6eb720b3be7c423c156453c70c07dc
Review mode: triage-approved (single reviewer)
Summary
Adds persona-mention to the cross-repo agent allowlist in scripts/cut-release.sh (case arm in cross_repo_agent(), usage comment, and the unknown-agent error string), with two new bats tests mirroring the existing pr-review-mention pattern. The classification was independently verified: persona-mention-reusable.yml exists in petry-projects/.github (the CROSS_REPO_TARGET host), and this repo's persona-runner.yml subscribes to the persona-mention repository_dispatch — exactly analogous to pr-review-mention, so release/channel tags correctly resolve against the .github host repo. The change is mechanical, self-consistent across all three touched locations, and test-covered (61/61 bats pass in CI).
Linked issue analysis
No linked closing issues. The PR body cites #754 (canary-ring registration) and the persona-mention framework work (#1293, merged) as motivating context; this PR is the stated prerequisite for cutting the next-ring release of persona-mention. Motivation is clear and consistent with the merged persona runtime on main.
Findings
No blocking findings.
- Correctness: the three edits (allowlist, usage comment, error message) are consistent;
valid_agent()delegates tocross_repo_agent(), so the new agent is accepted end-to-end. Verifiedpersona-mention-reusable.ymlexists inpetry-projects/.github, confirming the cross-repo classification. - Tests: two new bats tests cover both
valid_agentacceptance andcross_repo_agentclassification, matching the established pattern. - Security: no auth/secrets/crypto surface; pure allowlist extension in release tooling. gitleaks passed. The
run_secret_scanningMCP tool was unavailable in this run (Secret Protection MCP not exposed); the gitleaks CI check covers secret scanning. - Review threads: none open; CodeRabbit approved, Gemini/Copilot left comment-only reviews with no inline threads or unanswered questions.
CI status
All required checks pass: SonarCloud ✓, CodeQL ✓, agent-shield / AgentShield ✓, dependency-audit / Detect ecosystems ✓. Substantive non-required checks also green: shellcheck, bats, unit-tests, gitleaks, actionlint, Lint, holdout-guard, caller-stub-freeze, template-drift. The CANCELLED dev-lead / dispatch and dev-lead / ci-relay entries are non-required agent-orchestration runs (rate-limited/superseded), not validation checks.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
Registering
persona-mentionincanary-rings.json(#754) isn't enough to cut its release —cut-release.shkeeps its own hardcoded agent allowlist, and the router was absent, socut-release.sh persona-mention 1.0.0 --channel nextfails with unknown agent. (Two-registry drift, in the release tooling.)persona-mentionis cross-repo exactly likepr-review-mention: its reusable lives inpetry-projects/.github, this repo holds only the stub, so its tags resolve against.github. Added it besidepr-review-mentionincross_repo_agent(), the usage comment, and the error string.bats tests/test_cut_release.bats— 61/61 (2 new)shellcheck— cleanPrerequisite for the
next-ring activation of the persona mention framework.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
persona-mentionagent when preparing releases.persona-mentionas a cross-repository agent.Bug Fixes
Tests