Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @petoju
As described here #176 I have tried to add support for mysql discard password. I have tested the provider locally to one of my RDS instances
I also tested changing the password with enabling the 2 property retain_old_passowrd and discard_old_password. incase a user does that by mistake, the discard_old_password is doing nth so the new password will be created and the old password will be retained.
What I am not so sure about is the test cases. I tried to add the functions and use cases which i described above but maybe i am missing something.
Happy to get your feedback.