Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sorting of initiative members #3

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Improve sorting of initiative members #3

merged 2 commits into from
Aug 29, 2021

Conversation

petertrr
Copy link
Owner

What's done:

  • Extract sorting logic into an interface
  • Sort by base modifier if initiatives are equal

### What's done:
* Extract sorting logic into an interface
* Sort by base modifier if initiatives are equal
### What's done:
* Extract sorting logic into an interface
* Sort by base modifier if initiatives are equal
@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #3 (1a79547) into main (3177b5c) will decrease coverage by 0.31%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #3      +/-   ##
============================================
- Coverage     83.78%   83.47%   -0.32%     
- Complexity       31       34       +3     
============================================
  Files             4        5       +1     
  Lines           111      121      +10     
  Branches         17       19       +2     
============================================
+ Hits             93      101       +8     
- Misses            9       10       +1     
- Partials          9       10       +1     
Flag Coverage Δ
unittests 83.47% <81.81%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ithub/petertrr/initbot/sorting/DescendantSorter.kt 77.77% <77.77%> (ø)
...in/kotlin/io/github/petertrr/initbot/Initiative.kt 78.87% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3177b5c...1a79547. Read the comment docs.

@petertrr petertrr merged commit 2c5b72e into main Aug 29, 2021
@petertrr petertrr deleted the feature/sorting branch August 29, 2021 10:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant